From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael Walle" <michael@walle.cc>,
"Jan Kiszka" <jan.kiszka@web.de>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory
Date: Fri, 15 Mar 2013 17:19:29 +0100 [thread overview]
Message-ID: <51434A11.9020904@redhat.com> (raw)
In-Reply-To: <CAFEAcA_fr_VGoVm3eun8PintuGY4=cFJ08sO2p4YKY5+R581Mg@mail.gmail.com>
Il 15/03/2013 17:09, Peter Maydell ha scritto:
> On 15 March 2013 16:00, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 15/03/2013 15:34, Peter Maydell ha scritto:
>>> I rather suspect sysbus_add_io and sysbus_del_io should also be
>>> removed, but since their users are in PPC and x86 platforms I'll
>>> let somebody else do that part :-)
>>
>> sysbus_add_io and sysbus_del_io are actually a good match for the I/O
>> address space of x86, because the model was to have "well-known" port
>> numbers standardized across all platforms. So all the boards would have
>> to know those port addresses if we used sysbus_init_mmio.
>
> Maybe they should just call memory_region_add_subregion()
> directly then? There's nothing sysbus-device-specific about
> what these functions do, they just take a SysBusDevice* and
> totally ignore it...
It affects the OpenFirmware path, but perhaps we can move the
get_fw_dev_path from the Bus to the Device class.
Paolo
next prev parent reply other threads:[~2013-03-15 16:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 14:34 [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory Peter Maydell
2013-03-15 14:34 ` [Qemu-devel] [PATCH v3 1/5] sysbus: make SysBusDeviceClass::init optional Peter Maydell
2013-03-15 14:34 ` [Qemu-devel] [PATCH v3 2/5] musicpal: qdevify musicpal-misc Peter Maydell
2013-03-28 15:14 ` Andreas Färber
2013-03-15 14:34 ` [Qemu-devel] [PATCH v3 3/5] milkymist-minimac2: Just expose buffers as a sysbus mmio region Peter Maydell
2013-03-15 14:34 ` [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory regions in the device itself Peter Maydell
2013-03-28 17:55 ` Anthony Liguori
2013-03-28 18:31 ` Michael Walle
2013-03-28 18:33 ` Peter Maydell
2013-03-28 18:37 ` Michael Walle
2013-03-15 14:34 ` [Qemu-devel] [PATCH v3 5/5] sysbus: Remove sysbus_add_memory and sysbus_del_memory Peter Maydell
2013-03-15 16:00 ` [Qemu-devel] [PATCH v3 0/5] " Paolo Bonzini
2013-03-15 16:09 ` Peter Maydell
2013-03-15 16:19 ` Paolo Bonzini [this message]
2013-03-28 11:25 ` Peter Maydell
2013-03-28 15:15 ` Andreas Färber
2013-03-28 15:24 ` Peter Maydell
2013-03-28 15:38 ` Paolo Bonzini
2013-03-28 15:56 ` Anthony Liguori
2013-03-28 17:16 ` Peter Maydell
2013-04-01 20:48 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51434A11.9020904@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=jan.kiszka@web.de \
--cc=michael@walle.cc \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.