From: Marek Vasut <marex@denx.de>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
jimwall@q.com, brian@crystalfontz.com,
Maxime Rpard <maxime.ripard@free-electrons.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2] iio: mxs-lradc: Do hardware initialization earlier
Date: Thu, 28 Mar 2013 23:58:08 +0100 [thread overview]
Message-ID: <201303282358.08630.marex@denx.de> (raw)
In-Reply-To: <1364508273-14955-1-git-send-email-alexandre.belloni@free-electrons.com>
Dear Alexandre Belloni,
> We need to initialize hardware before registering the touchscreen. Else,
> we end up setting registers in mxs_lradc_ts_open(), getting called just
> after registering the touchscreen with input_register_device() and by
> the end of mxs_lradc_probe(), we reset the LRADC block hence losing the
> correct configuration.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Marek Vasut <marex@denx.de>
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] iio: mxs-lradc: Do hardware initialization earlier
Date: Thu, 28 Mar 2013 23:58:08 +0100 [thread overview]
Message-ID: <201303282358.08630.marex@denx.de> (raw)
In-Reply-To: <1364508273-14955-1-git-send-email-alexandre.belloni@free-electrons.com>
Dear Alexandre Belloni,
> We need to initialize hardware before registering the touchscreen. Else,
> we end up setting registers in mxs_lradc_ts_open(), getting called just
> after registering the touchscreen with input_register_device() and by
> the end of mxs_lradc_probe(), we reset the LRADC block hence losing the
> correct configuration.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Marek Vasut <marex@denx.de>
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-03-28 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 22:04 [PATCH v2] iio: mxs-lradc: Do hardware initialization earlier Alexandre Belloni
2013-03-28 22:04 ` Alexandre Belloni
2013-03-28 22:58 ` Marek Vasut [this message]
2013-03-28 22:58 ` Marek Vasut
2013-03-29 9:30 ` Jonathan Cameron
2013-03-29 9:30 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303282358.08630.marex@denx.de \
--to=marex@denx.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=brian@crystalfontz.com \
--cc=fabio.estevam@freescale.com \
--cc=jic23@kernel.org \
--cc=jimwall@q.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.