From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource: Fix build in non-OF case
Date: Fri, 29 Mar 2013 18:30:01 +0000 [thread overview]
Message-ID: <20130329183001.GK18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201303281447.51532.arnd@arndb.de>
On Thu, Mar 28, 2013 at 02:47:51PM +0000, Arnd Bergmann wrote:
> Since we recently introduced the IS_ENABLED() macro to test for preprocessor
> symbols, I think there is a general trend away from any #ifdefs in driver
> code.
I have to say I'm not seeing any evidence of this in the patches I'm
seeing, and I'm not sure what the connection with IS_ENABLED() is? It's
a reasonable idea, just likely to surprise people given the amount of
boilerplate we've got for things like PM - I guess we'd need to make
sure those macros do references as well, they're the main users of
ifdefs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130329/fa5af154/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Rob Herring <robherring2@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Tomasz Figa <tomasz.figa@gmail.com>,
Axel Lin <axel.lin@ingics.com>
Subject: Re: [PATCH] clocksource: Fix build in non-OF case
Date: Fri, 29 Mar 2013 18:30:01 +0000 [thread overview]
Message-ID: <20130329183001.GK18316@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201303281447.51532.arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
On Thu, Mar 28, 2013 at 02:47:51PM +0000, Arnd Bergmann wrote:
> Since we recently introduced the IS_ENABLED() macro to test for preprocessor
> symbols, I think there is a general trend away from any #ifdefs in driver
> code.
I have to say I'm not seeing any evidence of this in the patches I'm
seeing, and I'm not sure what the connection with IS_ENABLED() is? It's
a reasonable idea, just likely to surprise people given the amount of
boilerplate we've got for things like PM - I guess we'd need to make
sure those macros do references as well, they're the main users of
ifdefs.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-03-29 18:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 12:30 [PATCH] clocksource: Fix build in non-OF case Mark Brown
2013-03-28 12:30 ` Mark Brown
2013-03-28 12:39 ` Arnd Bergmann
2013-03-28 12:39 ` Arnd Bergmann
2013-03-28 12:55 ` Mark Brown
2013-03-28 12:55 ` Mark Brown
2013-03-28 13:08 ` Arnd Bergmann
2013-03-28 13:08 ` Arnd Bergmann
2013-03-28 13:10 ` Mark Brown
2013-03-28 13:10 ` Mark Brown
2013-03-28 14:47 ` Arnd Bergmann
2013-03-28 14:47 ` Arnd Bergmann
2013-03-29 18:30 ` Mark Brown [this message]
2013-03-29 18:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130329183001.GK18316@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.