From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: target-devel <target-devel@vger.kernel.org>,
lf-virt <virtualization@lists.linux-foundation.org>,
kvm-devel <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/3] virtio/vhost: Add checks for uninitialized VQs
Date: Sun, 31 Mar 2013 10:46:00 +0300 [thread overview]
Message-ID: <20130331074559.GD23484@redhat.com> (raw)
In-Reply-To: <1364531592-8368-1-git-send-email-nab@linux-iscsi.org>
On Fri, Mar 29, 2013 at 04:33:09AM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> Hi folks,
>
> This series adds a virtio_queue_valid() for use by virtio-pci code in
> order to prevent opreations upon uninitialized VQs, that is currently
> expected to occur during seabios setup of virtio-scsi.
>
> This also includes a vhost specific check for uninitialized VQs in
> vhost_verify_ring_mappings() to avoid this same case.
>
> Please review.
>
> --nab
Okay, and does this fix the failures in vhost_verify_ring_mappings
that you've observed?
> Michael S. Tsirkin (1):
> virtio: add API to check that ring is setup
>
> Nicholas Bellinger (2):
> virtio-pci: Add virtio_queue_valid checks ahead of
> virtio_queue_get_num
> vhost: Check+skip uninitialized VQs in vhost_verify_ring_mappings
>
> hw/vhost.c | 3 +++
> hw/virtio-pci.c | 27 +++++++++++++++++++++++++++
> hw/virtio.c | 5 +++++
> hw/virtio.h | 1 +
> 4 files changed, 36 insertions(+), 0 deletions(-)
>
> --
> 1.7.2.5
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>,
lf-virt <virtualization@lists.linux-foundation.org>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
target-devel <target-devel@vger.kernel.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] virtio/vhost: Add checks for uninitialized VQs
Date: Sun, 31 Mar 2013 10:46:00 +0300 [thread overview]
Message-ID: <20130331074559.GD23484@redhat.com> (raw)
In-Reply-To: <1364531592-8368-1-git-send-email-nab@linux-iscsi.org>
On Fri, Mar 29, 2013 at 04:33:09AM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> Hi folks,
>
> This series adds a virtio_queue_valid() for use by virtio-pci code in
> order to prevent opreations upon uninitialized VQs, that is currently
> expected to occur during seabios setup of virtio-scsi.
>
> This also includes a vhost specific check for uninitialized VQs in
> vhost_verify_ring_mappings() to avoid this same case.
>
> Please review.
>
> --nab
Okay, and does this fix the failures in vhost_verify_ring_mappings
that you've observed?
> Michael S. Tsirkin (1):
> virtio: add API to check that ring is setup
>
> Nicholas Bellinger (2):
> virtio-pci: Add virtio_queue_valid checks ahead of
> virtio_queue_get_num
> vhost: Check+skip uninitialized VQs in vhost_verify_ring_mappings
>
> hw/vhost.c | 3 +++
> hw/virtio-pci.c | 27 +++++++++++++++++++++++++++
> hw/virtio.c | 5 +++++
> hw/virtio.h | 1 +
> 4 files changed, 36 insertions(+), 0 deletions(-)
>
> --
> 1.7.2.5
next prev parent reply other threads:[~2013-03-31 7:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 4:33 [PATCH 0/3] virtio/vhost: Add checks for uninitialized VQs Nicholas A. Bellinger
2013-03-29 4:33 ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-29 4:33 ` [PATCH 1/3] virtio: add API to check that ring is setup Nicholas A. Bellinger
2013-03-29 4:33 ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-29 4:33 ` Nicholas A. Bellinger
2013-03-29 4:33 ` [PATCH 2/3] virtio-pci: Add virtio_queue_valid checks ahead of virtio_queue_get_num Nicholas A. Bellinger
2013-03-29 4:33 ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-31 7:37 ` Michael S. Tsirkin
2013-03-31 7:37 ` Michael S. Tsirkin
2013-03-31 7:37 ` [Qemu-devel] " Michael S. Tsirkin
2013-04-01 23:16 ` Nicholas A. Bellinger
2013-04-01 23:16 ` Nicholas A. Bellinger
2013-04-01 23:16 ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-29 4:33 ` [PATCH 3/3] vhost: Check+skip uninitialized VQs in vhost_verify_ring_mappings Nicholas A. Bellinger
2013-03-29 4:33 ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-31 7:45 ` Michael S. Tsirkin
2013-03-31 7:45 ` [Qemu-devel] " Michael S. Tsirkin
2013-04-01 23:49 ` Nicholas A. Bellinger
2013-04-01 23:49 ` Nicholas A. Bellinger
2013-04-01 23:49 ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-29 4:33 ` Nicholas A. Bellinger
2013-03-31 7:46 ` Michael S. Tsirkin [this message]
2013-03-31 7:46 ` [Qemu-devel] [PATCH 0/3] virtio/vhost: Add checks for uninitialized VQs Michael S. Tsirkin
2013-04-01 23:51 ` Nicholas A. Bellinger
2013-04-01 23:51 ` Nicholas A. Bellinger
2013-04-01 23:51 ` [Qemu-devel] " Nicholas A. Bellinger
2013-03-31 7:46 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2013-03-29 4:33 Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130331074559.GD23484@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@linux.vnet.ibm.com \
--cc=asias@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.