Re: [PATCH 1/1] ibmvscsi: Fix slave_configure deadlock

[Robert Jennings <rcj@linux.vnet.ibm.com>]

* Brian King (brking@linux.vnet.ibm.com) wrote:
> 
> No locks should be held when calling scsi_adjust_queue_depth
> so drop the lock in slave_configure prior to calling it.
> 
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Acked-by: Robert Jennings <rcj@linux.vnet.ibm.com>
> ---
> 
>  drivers/scsi/ibmvscsi/ibmvscsi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_slave_configure_deadlock drivers/scsi/ibmvscsi/ibmvscsi.c
> --- linux/drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_slave_configure_deadlock	2013-03-06 16:36:26.000000000 -0600
> +++ linux-bjking1/drivers/scsi/ibmvscsi/ibmvscsi.c	2013-03-06 16:36:26.000000000 -0600
> @@ -1899,8 +1899,8 @@ static int ibmvscsi_slave_configure(stru
>  		sdev->allow_restart = 1;
>  		blk_queue_rq_timeout(sdev->request_queue, 120 * HZ);
>  	}
> -	scsi_adjust_queue_depth(sdev, 0, shost->cmd_per_lun);
>  	spin_unlock_irqrestore(shost->host_lock, lock_flags);
> +	scsi_adjust_queue_depth(sdev, 0, shost->cmd_per_lun);
>  	return 0;
>  }
> 
> _