* [PATCH 1/1] ibmvscsi: Fix slave_configure deadlock
@ 2013-04-01 14:44 Brian King
2013-04-01 14:49 ` Robert Jennings
0 siblings, 1 reply; 2+ messages in thread
From: Brian King @ 2013-04-01 14:44 UTC (permalink / raw)
To: James.Bottomley; +Cc: rcj, linux-scsi, brking
No locks should be held when calling scsi_adjust_queue_depth
so drop the lock in slave_configure prior to calling it.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_slave_configure_deadlock drivers/scsi/ibmvscsi/ibmvscsi.c
--- linux/drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_slave_configure_deadlock 2013-03-06 16:36:26.000000000 -0600
+++ linux-bjking1/drivers/scsi/ibmvscsi/ibmvscsi.c 2013-03-06 16:36:26.000000000 -0600
@@ -1899,8 +1899,8 @@ static int ibmvscsi_slave_configure(stru
sdev->allow_restart = 1;
blk_queue_rq_timeout(sdev->request_queue, 120 * HZ);
}
- scsi_adjust_queue_depth(sdev, 0, shost->cmd_per_lun);
spin_unlock_irqrestore(shost->host_lock, lock_flags);
+ scsi_adjust_queue_depth(sdev, 0, shost->cmd_per_lun);
return 0;
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ibmvscsi: Fix slave_configure deadlock
2013-04-01 14:44 [PATCH 1/1] ibmvscsi: Fix slave_configure deadlock Brian King
@ 2013-04-01 14:49 ` Robert Jennings
0 siblings, 0 replies; 2+ messages in thread
From: Robert Jennings @ 2013-04-01 14:49 UTC (permalink / raw)
To: Brian King; +Cc: James.Bottomley, linux-scsi
* Brian King (brking@linux.vnet.ibm.com) wrote:
>
> No locks should be held when calling scsi_adjust_queue_depth
> so drop the lock in slave_configure prior to calling it.
>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Acked-by: Robert Jennings <rcj@linux.vnet.ibm.com>
> ---
>
> drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_slave_configure_deadlock drivers/scsi/ibmvscsi/ibmvscsi.c
> --- linux/drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_slave_configure_deadlock 2013-03-06 16:36:26.000000000 -0600
> +++ linux-bjking1/drivers/scsi/ibmvscsi/ibmvscsi.c 2013-03-06 16:36:26.000000000 -0600
> @@ -1899,8 +1899,8 @@ static int ibmvscsi_slave_configure(stru
> sdev->allow_restart = 1;
> blk_queue_rq_timeout(sdev->request_queue, 120 * HZ);
> }
> - scsi_adjust_queue_depth(sdev, 0, shost->cmd_per_lun);
> spin_unlock_irqrestore(shost->host_lock, lock_flags);
> + scsi_adjust_queue_depth(sdev, 0, shost->cmd_per_lun);
> return 0;
> }
>
> _
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-01 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-01 14:44 [PATCH 1/1] ibmvscsi: Fix slave_configure deadlock Brian King
2013-04-01 14:49 ` Robert Jennings
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.