All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] iommu/amd: Add IOMMU event log injection interface for testing event flag decoding logic
Date: Tue, 2 Apr 2013 16:35:22 +0200	[thread overview]
Message-ID: <20130402143521.GC15687@8bytes.org> (raw)
In-Reply-To: <1364428294-2579-1-git-send-email-suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>

On Wed, Mar 27, 2013 at 06:51:34PM -0500, suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
> 
> Add IOMMU event log injection interface for testing event flag decoding logic.
> This interface allows users to specify device id, event flag, and event types via debugfs.
> 
> echo 0x300 > /sys/kernel/debug/amd-iommu-evninj/devid // (e.g. Bus:Dev.fun 3:0.0)
> echo 0xfff > /sys/kernel/debug/amd-iommu-evninj/flags // (e.g. Specify flag value)
> echo 2 > /sys/kernel/debug/amd-iommu-evninj/type      // (e.g. for IO_PAGE_FAULT event)
> 
> Once the event is injected, IOMMU driver will parse and print out the event information
> in kernel log (dmesg) with the various information depending on the types of event and flag
> specified.

Why is this needed? I think the risk of regressions in the
event-handling code is to low to justify the need for an event-injection
mechanism.

	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: suravee.suthikulpanit@amd.com
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iommu/amd: Add IOMMU event log injection interface for testing event flag decoding logic
Date: Tue, 2 Apr 2013 16:35:22 +0200	[thread overview]
Message-ID: <20130402143521.GC15687@8bytes.org> (raw)
In-Reply-To: <1364428294-2579-1-git-send-email-suravee.suthikulpanit@amd.com>

On Wed, Mar 27, 2013 at 06:51:34PM -0500, suravee.suthikulpanit@amd.com wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 
> Add IOMMU event log injection interface for testing event flag decoding logic.
> This interface allows users to specify device id, event flag, and event types via debugfs.
> 
> echo 0x300 > /sys/kernel/debug/amd-iommu-evninj/devid // (e.g. Bus:Dev.fun 3:0.0)
> echo 0xfff > /sys/kernel/debug/amd-iommu-evninj/flags // (e.g. Specify flag value)
> echo 2 > /sys/kernel/debug/amd-iommu-evninj/type      // (e.g. for IO_PAGE_FAULT event)
> 
> Once the event is injected, IOMMU driver will parse and print out the event information
> in kernel log (dmesg) with the various information depending on the types of event and flag
> specified.

Why is this needed? I think the risk of regressions in the
event-handling code is to low to justify the need for an event-injection
mechanism.

	Joerg



  parent reply	other threads:[~2013-04-02 14:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 23:51 [PATCH 2/3] iommu/amd: Add IOMMU event log injection interface for testing event flag decoding logic suravee.suthikulpanit-5C7GfCeVMHo
2013-03-27 23:51 ` suravee.suthikulpanit
     [not found] ` <1364428294-2579-1-git-send-email-suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2013-04-02 14:35   ` Joerg Roedel [this message]
2013-04-02 14:35     ` Joerg Roedel
     [not found]     ` <20130402143521.GC15687-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-02 14:44       ` Suravee Suthikulanit
2013-04-02 14:44         ` Suravee Suthikulanit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130402143521.GC15687@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.