From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Matthew Garrett <matthew.garrett@nebula.com>,
Zhang Rui <rui.zhang@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver
Date: Tue, 2 Apr 2013 16:33:57 -0700 [thread overview]
Message-ID: <20130402163357.72dac902@chromoly> (raw)
In-Reply-To: <20130402230042.GA8713@kroah.com>
On Tue, 2 Apr 2013 16:00:42 -0700
Greg KH <gregkh@linuxfoundation.org> wrote:
> > +#include "intel_rapl.h"
> > +#include "../../../fs/sysfs/sysfs.h"
>
> WTF?
>
> Oh, that's a sure sign you are not doing something properly, if you
> think it's ok to muck around with the internals of sysfs.
>
> There's a reason that file is "private", why do you think it's ok to
> use it directly? Did you just think that I somehow "forgot" to put
> it in the proper include directory?
I did feel unsure about this but i saw some precedence in the kernel.
Anyway, I needed a way to validate a userspace file passed to rapl
driver belong to the same sysfs directory. I will look for alternative
ways.
--
Thanks,
Jacob
next prev parent reply other threads:[~2013-04-02 23:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 22:15 [PATCH 0/1] RAPL (Running Average Power Limit) driver Jacob Pan
2013-04-02 22:15 ` [PATCH 1/1] Introduce Intel RAPL cooling device driver Jacob Pan
2013-04-02 21:42 ` Randy Dunlap
2013-04-02 21:47 ` Randy Dunlap
2013-04-02 23:04 ` Greg Kroah-Hartman
2013-04-02 22:35 ` Joe Perches
2013-04-02 23:00 ` Greg KH
2013-04-02 23:03 ` Greg KH
2013-04-02 23:33 ` Jacob Pan [this message]
2013-04-02 23:48 ` Greg KH
2013-04-03 0:17 ` Jacob Pan
2013-04-03 16:30 ` Greg KH
2013-04-03 18:03 ` Jacob Pan
2013-04-05 20:24 ` Greg KH
2013-04-02 23:53 ` Jacob Pan
2013-04-03 0:13 ` Greg KH
2013-04-03 4:48 ` Jacob Pan
2013-04-03 16:35 ` Greg KH
2013-04-03 17:35 ` Jacob Pan
2013-04-05 20:23 ` Greg KH
2013-04-05 21:33 ` Jacob Pan
2013-04-05 21:46 ` Greg KH
2013-04-03 10:24 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402163357.72dac902@chromoly \
--to=jacob.jun.pan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.