From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Matthew Garrett <matthew.garrett@nebula.com>,
Zhang Rui <rui.zhang@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver
Date: Tue, 2 Apr 2013 16:04:35 -0700 [thread overview]
Message-ID: <20130402230435.GA9462@kroah.com> (raw)
In-Reply-To: <515B51F7.6070901@infradead.org>
On Tue, Apr 02, 2013 at 02:47:35PM -0700, Randy Dunlap wrote:
> On 04/02/13 15:15, Jacob Pan wrote:
> > diff --git a/drivers/platform/x86/intel_rapl.c b/drivers/platform/x86/intel_rapl.c
> > new file mode 100644
> > index 0000000..56ee928
> > --- /dev/null
> > +++ b/drivers/platform/x86/intel_rapl.c
> > @@ -0,0 +1,1323 @@
> > +/*
> > + * intel_rapl.c - Intel Running Average Power Limit Driver for MSR based
> > + * RAPL interface
> > + *
> > + * Copyright (c) 2013, Intel Corporation.
> > + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > +#include <linux/sysfs.h>
> > +
>
> > +#include "../../../fs/sysfs/sysfs.h"
>
>
> What does this driver need from ^^^^^^ that file, which says:
>
> * fs/sysfs/sysfs.h - sysfs internal header file
>
> and should that be moved to include/linux/sysfs.h ?
See my other complain about this already, I beat you to it :)
greg k-h
next prev parent reply other threads:[~2013-04-02 23:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 22:15 [PATCH 0/1] RAPL (Running Average Power Limit) driver Jacob Pan
2013-04-02 22:15 ` [PATCH 1/1] Introduce Intel RAPL cooling device driver Jacob Pan
2013-04-02 21:42 ` Randy Dunlap
2013-04-02 21:47 ` Randy Dunlap
2013-04-02 23:04 ` Greg Kroah-Hartman [this message]
2013-04-02 22:35 ` Joe Perches
2013-04-02 23:00 ` Greg KH
2013-04-02 23:03 ` Greg KH
2013-04-02 23:33 ` Jacob Pan
2013-04-02 23:48 ` Greg KH
2013-04-03 0:17 ` Jacob Pan
2013-04-03 16:30 ` Greg KH
2013-04-03 18:03 ` Jacob Pan
2013-04-05 20:24 ` Greg KH
2013-04-02 23:53 ` Jacob Pan
2013-04-03 0:13 ` Greg KH
2013-04-03 4:48 ` Jacob Pan
2013-04-03 16:35 ` Greg KH
2013-04-03 17:35 ` Jacob Pan
2013-04-05 20:23 ` Greg KH
2013-04-05 21:33 ` Jacob Pan
2013-04-05 21:46 ` Greg KH
2013-04-03 10:24 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402230435.GA9462@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arjan@linux.intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.