All of lore.kernel.org
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] clk: add si5351 i2c common clock driver
Date: Tue, 02 Apr 2013 16:46:48 -0700	[thread overview]
Message-ID: <20130402234648.8177.86213@quantum> (raw)
In-Reply-To: <1364050010-23919-1-git-send-email-sebastian.hesselbarth@gmail.com>

Quoting Sebastian Hesselbarth (2013-03-23 07:46:50)
> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
> new file mode 100644
> index 0000000..9d0c210
> --- /dev/null
> +++ b/drivers/clk/clk-si5351.c
> @@ -0,0 +1,1411 @@
> +/*
> + * clk-si5351.c: Silicon Laboratories Si5351A/B/C I2C Clock Generator
> + *
> + * Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> + * Rabeeh Khoury <rabeeh@solid-run.com>
> + *
> + * References:
> + * [1] "Si5351A/B/C Data Sheet"
> + *     http://www.silabs.com/Support%20Documents/TechnicalDocs/Si5351.pdf
> + * [2] "Manually Generating an Si5351 Register Map"
> + *     http://www.silabs.com/Support%20Documents/TechnicalDocs/AN619.pdf
> + *
> + * This program is free software; you can redistribute  it and/or modify it
> + * under  the terms of  the GNU General  Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <linux/clk-private.h>

I hope that this is supposed to be clk-provider.h.  I don't plan on
taking in any more clock drivers that depend on clk-private.h.  I didn't
see any reason for this patch to not use clk-provider.h.

Regards,
Mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>Sebastian
	Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	Rob Landley <rob@landley.net>,
	Stephen Warren <swarren@nvidia.com>,
	Thierry Reding <thierry.reding@avionic-design.de>,
	Dom Cobley <popcornmix@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Rabeeh Khoury <rabeeh@solid-run.com>,
	Daniel Mack <zonque@gmail.com>,
	Jean-Francois Moine <moinejf@free.fr>,
	Lars-Peter Clausen <lars@metafoo.de>,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4] clk: add si5351 i2c common clock driver
Date: Tue, 02 Apr 2013 16:46:48 -0700	[thread overview]
Message-ID: <20130402234648.8177.86213@quantum> (raw)
In-Reply-To: <1364050010-23919-1-git-send-email-sebastian.hesselbarth@gmail.com>

Quoting Sebastian Hesselbarth (2013-03-23 07:46:50)
> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
> new file mode 100644
> index 0000000..9d0c210
> --- /dev/null
> +++ b/drivers/clk/clk-si5351.c
> @@ -0,0 +1,1411 @@
> +/*
> + * clk-si5351.c: Silicon Laboratories Si5351A/B/C I2C Clock Generator
> + *
> + * Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> + * Rabeeh Khoury <rabeeh@solid-run.com>
> + *
> + * References:
> + * [1] "Si5351A/B/C Data Sheet"
> + *     http://www.silabs.com/Support%20Documents/TechnicalDocs/Si5351.pdf
> + * [2] "Manually Generating an Si5351 Register Map"
> + *     http://www.silabs.com/Support%20Documents/TechnicalDocs/AN619.pdf
> + *
> + * This program is free software; you can redistribute  it and/or modify it
> + * under  the terms of  the GNU General  Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <linux/clk-private.h>

I hope that this is supposed to be clk-provider.h.  I don't plan on
taking in any more clock drivers that depend on clk-private.h.  I didn't
see any reason for this patch to not use clk-provider.h.

Regards,
Mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	Rob Landley <rob@landley.net>,
	Stephen Warren <swarren@nvidia.com>,
	Thierry Reding <thierry.reding@avionic-design.de>,
	Dom Cobley <popcornmix@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Rabeeh Khoury <rabeeh@solid-run.com>,
	Daniel Mack <zonque@gmail.com>,
	Jean-Francois Moine <moinejf@free.fr>,
	Lars-Peter Clausen <lars@metafoo.de>,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4] clk: add si5351 i2c common clock driver
Date: Tue, 02 Apr 2013 16:46:48 -0700	[thread overview]
Message-ID: <20130402234648.8177.86213@quantum> (raw)
In-Reply-To: <1364050010-23919-1-git-send-email-sebastian.hesselbarth@gmail.com>

Quoting Sebastian Hesselbarth (2013-03-23 07:46:50)
> diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
> new file mode 100644
> index 0000000..9d0c210
> --- /dev/null
> +++ b/drivers/clk/clk-si5351.c
> @@ -0,0 +1,1411 @@
> +/*
> + * clk-si5351.c: Silicon Laboratories Si5351A/B/C I2C Clock Generator
> + *
> + * Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> + * Rabeeh Khoury <rabeeh@solid-run.com>
> + *
> + * References:
> + * [1] "Si5351A/B/C Data Sheet"
> + *     http://www.silabs.com/Support%20Documents/TechnicalDocs/Si5351.pdf
> + * [2] "Manually Generating an Si5351 Register Map"
> + *     http://www.silabs.com/Support%20Documents/TechnicalDocs/AN619.pdf
> + *
> + * This program is free software; you can redistribute  it and/or modify it
> + * under  the terms of  the GNU General  Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <linux/clk-private.h>

I hope that this is supposed to be clk-provider.h.  I don't plan on
taking in any more clock drivers that depend on clk-private.h.  I didn't
see any reason for this patch to not use clk-provider.h.

Regards,
Mike

  reply	other threads:[~2013-04-02 23:46 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-09 12:59 [PATCH] clk: add si5351 i2c common clock driver Sebastian Hesselbarth
2013-02-09 12:59 ` Sebastian Hesselbarth
2013-02-11  5:46 ` Mike Turquette
2013-02-11  5:46   ` Mike Turquette
2013-02-11  5:46   ` Mike Turquette
2013-02-11  9:52   ` Sebastian Hesselbarth
2013-02-11  9:52     ` Sebastian Hesselbarth
2013-02-18 10:19 ` Daniel Mack
2013-02-18 10:19   ` Daniel Mack
2013-02-19 19:15 ` Daniel Mack
2013-02-19 19:15   ` Daniel Mack
2013-02-19 19:15   ` Daniel Mack
2013-02-27 10:01   ` Sebastian Hesselbarth
2013-02-27 10:01     ` Sebastian Hesselbarth
2013-03-01 15:01     ` Daniel Mack
2013-03-01 15:01       ` Daniel Mack
2013-03-16 13:10 ` [PATCH v2] " Sebastian Hesselbarth
2013-03-16 13:10   ` Sebastian Hesselbarth
2013-03-16 15:10   ` Daniel Mack
2013-03-16 15:10     ` Daniel Mack
2013-03-18 10:43 ` [PATCH v3] " Sebastian Hesselbarth
2013-03-18 10:43   ` Sebastian Hesselbarth
2013-03-18 11:37   ` Daniel Mack
2013-03-18 11:37     ` Daniel Mack
2013-03-20  0:26   ` Mike Turquette
2013-03-20  0:26     ` Mike Turquette
2013-03-20  0:26     ` Mike Turquette
2013-03-20  8:20     ` Sebastian Hesselbarth
2013-03-20  8:20       ` Sebastian Hesselbarth
2013-03-21 18:09   ` Lars-Peter Clausen
2013-03-21 18:09     ` Lars-Peter Clausen
2013-03-21 21:32     ` Sebastian Hesselbarth
2013-03-21 21:32       ` Sebastian Hesselbarth
2013-03-23 10:07       ` Lars-Peter Clausen
2013-03-23 10:07         ` Lars-Peter Clausen
2013-03-23 14:46   ` [PATCH v4] " Sebastian Hesselbarth
2013-03-23 14:46     ` Sebastian Hesselbarth
2013-03-23 14:46     ` Sebastian Hesselbarth
2013-04-02 23:46     ` Mike Turquette [this message]
2013-04-02 23:46       ` Mike Turquette
2013-04-02 23:46       ` Mike Turquette
2013-04-03 11:10       ` Sebastian Hesselbarth
2013-04-03 11:10         ` Sebastian Hesselbarth
2013-04-05  5:23     ` [PATCH v5] " Sebastian Hesselbarth
2013-04-05  5:23       ` Sebastian Hesselbarth
2013-04-07 22:50       ` [v5] " Guenter Roeck
2013-04-07 22:50         ` Guenter Roeck
2013-04-07 23:49         ` Sebastian Hesselbarth
2013-04-07 23:49           ` Sebastian Hesselbarth
2013-04-08  0:17           ` Guenter Roeck
2013-04-08  0:17             ` Guenter Roeck
2013-04-08  6:11             ` Sebastian Hesselbarth
2013-04-08  6:11               ` Sebastian Hesselbarth
2013-04-08 14:54               ` Guenter Roeck
2013-04-08 14:54                 ` Guenter Roeck
2013-04-08 14:54                 ` Guenter Roeck
2013-04-08 15:38                 ` Sebastian Hesselbarth
2013-04-08 15:38                   ` Sebastian Hesselbarth
2013-04-08 15:38                   ` Sebastian Hesselbarth
2013-04-08 17:36                   ` Mike Turquette
2013-04-08 17:36                     ` Mike Turquette
2013-04-08 18:32                     ` Sebastian Hesselbarth
2013-04-08 18:32                       ` Sebastian Hesselbarth
2013-04-08 16:46       ` [PATCH v6] " Sebastian Hesselbarth
2013-04-08 16:46         ` Sebastian Hesselbarth
2013-04-08 17:46         ` Guenter Roeck
2013-04-08 17:46           ` Guenter Roeck
2013-04-08 18:24           ` Sebastian Hesselbarth
2013-04-08 18:24             ` Sebastian Hesselbarth
2013-04-10  9:40         ` [PATCH v7] " Sebastian Hesselbarth
2013-04-10  9:40           ` Sebastian Hesselbarth
2013-04-10  9:40           ` Sebastian Hesselbarth
2013-04-10 10:17           ` Daniel Mack
2013-04-10 10:17             ` Daniel Mack
2013-04-10 14:48             ` Michal Bachraty
2013-04-10 14:48               ` Michal Bachraty
2013-04-10 16:34               ` Sebastian Hesselbarth
2013-04-10 17:27               ` Sebastian Hesselbarth
2013-04-10 17:27                 ` Sebastian Hesselbarth
2013-04-10 17:27                 ` Sebastian Hesselbarth
2013-04-11  7:44                 ` Michal Bachraty
2013-04-11  7:44                   ` Michal Bachraty
2013-04-11  8:22                   ` Sebastian Hesselbarth
2013-04-11  8:22                     ` Sebastian Hesselbarth
2013-04-10 19:34           ` Guenter Roeck
2013-04-10 19:34             ` Guenter Roeck
2013-04-11 19:42           ` [PATCH v8] " Sebastian Hesselbarth
2013-04-11 19:42             ` Sebastian Hesselbarth
2013-04-11 19:42             ` Sebastian Hesselbarth
2013-04-12 11:43             ` Michal Bachraty
2013-04-12 11:43               ` Michal Bachraty
2013-04-12 11:43               ` Michal Bachraty
2013-04-12 18:19             ` Mike Turquette
2013-04-12 18:19               ` Mike Turquette
2013-04-12 18:19               ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130402234648.8177.86213@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.