From: Patrick McHardy <kaber@trash.net>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: jon.maloy@ericsson.com, allan.stephens@windriver.com,
netdev@vger.kernel.org, roland@kernel.org, sean.hefty@intel.com,
hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH 5/5] IPoIB: add support for TIPC protocol
Date: Wed, 3 Apr 2013 17:44:55 +0200 [thread overview]
Message-ID: <20130403154455.GM21481@macbook.localnet> (raw)
In-Reply-To: <515C4B65.4040600@mellanox.com>
On Wed, Apr 03, 2013 at 06:31:49PM +0300, Or Gerlitz wrote:
> On 03/04/2013 15:43, Patrick McHardy wrote:
> >[...] all TIPC needs to know about is ARP and RARP since
> >it wants to always perform "path find", even if a path is already known. [...]
>
> Not sure to follow this part... did you mean "all IPoIB needs to
> know about is ARP or RARP", this makes
> sense indeed, since for arp/rarp we want to call unicast_arp_send
> which does path_find and looks
> also for the case the path isn't valid
What I meant is that it doesn't require any knowledge about IPv4/IPv6 or
other higher layer protocols anymore. At least almost none.
We have protocol knowledge in ipoib_start_xmit(). For broadcast packets,
it drops unknown protocols. For unicast packets, it handles ARP/RARP
seperately because of the path find differences, IP/IPv6 are sent
using the neigh, all others are dropped.
ipoib_cm also has knowledge about IPv4/IPv6 in order to send ICMP errors.
What we could do instead of adding TIPC to the broadcast-don't-drop list
and to the send-using-neigh list in ipoib_start_xmit() is to only treat
ARP/RARP special and send every other protocol using the neigh or
ipoib_mcast_send().
Right now the supported protocols are artificially limited without a
technical reason.
next prev parent reply other threads:[~2013-04-03 15:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 12:43 [PATCH RFC 0/5] tipc: add support for TIPC over InfiniBand Patrick McHardy
2013-04-03 12:43 ` [PATCH 2/5] tipc: move bcast_addr from struct tipc_media to struct tipc_bearer Patrick McHardy
[not found] ` <1364993010-15515-1-git-send-email-kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2013-04-03 12:43 ` [PATCH 1/5] tipc: remove unused str2addr media callback Patrick McHardy
2013-04-03 12:43 ` [PATCH 3/5] tipc: set skb->protocol in eth_media packet transmission Patrick McHardy
2013-04-03 12:43 ` [PATCH 4/5] tipc: add InfiniBand media type Patrick McHardy
2013-04-03 14:41 ` Erik Hugne
2013-04-03 14:49 ` Patrick McHardy
[not found] ` <1364993010-15515-5-git-send-email-kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2013-04-07 9:07 ` Ying Xue
2013-04-07 9:07 ` Ying Xue
[not found] ` <51613740.6050501-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2013-04-07 12:04 ` Patrick McHardy
2013-04-07 9:19 ` Bart Van Assche
2013-04-07 9:43 ` Patrick McHardy
2013-04-03 12:43 ` [PATCH 5/5] IPoIB: add support for TIPC protocol Patrick McHardy
[not found] ` <1364993010-15515-6-git-send-email-kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2013-04-03 15:31 ` Or Gerlitz
2013-04-03 15:31 ` Or Gerlitz
2013-04-03 15:44 ` Patrick McHardy [this message]
2013-04-03 19:44 ` [PATCH RFC 0/5] tipc: add support for TIPC over InfiniBand Jon Maloy
2013-04-03 19:44 ` Jon Maloy
-- strict thread matches above, loose matches on Subject: below --
2013-04-17 16:18 [PATCH v2 0/5] tipc: add TIPC over Infiniband support Patrick McHardy
2013-04-17 16:18 ` [PATCH 5/5] IPoIB: add support for TIPC protocol Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403154455.GM21481@macbook.localnet \
--to=kaber@trash.net \
--cc=allan.stephens@windriver.com \
--cc=hal.rosenstock@gmail.com \
--cc=jon.maloy@ericsson.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.