From: Patrick McHardy <kaber@trash.net>
To: Bart Van Assche <bvanassche@acm.org>
Cc: jon.maloy@ericsson.com, allan.stephens@windriver.com,
netdev@vger.kernel.org, roland@kernel.org, sean.hefty@intel.com,
hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH 4/5] tipc: add InfiniBand media type
Date: Sun, 7 Apr 2013 11:43:45 +0200 [thread overview]
Message-ID: <20130407094345.GA24908@macbook.localnet> (raw)
In-Reply-To: <51613A0A.3060706@acm.org>
On Sun, Apr 07, 2013 at 11:19:06AM +0200, Bart Van Assche wrote:
> On 04/03/13 14:43, Patrick McHardy wrote:
> >diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h
> >+#ifdef CONFIG_TIPC_MEDIA_IB
> >+int tipc_ib_media_start(void);
> >+void tipc_ib_media_stop(void);
> >+#else
> >+int tipc_ib_media_start(void) { return 0; }
> >+void tipc_ib_media_stop(void) { return; }
> >+#endif
>
> Is the above a definition of a non-inline function pair in a header
> file ? I'm afraid that will cause trouble when including that header
> file in more than one source file.
Oops right, I'll fix that up.
next prev parent reply other threads:[~2013-04-07 9:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 12:43 [PATCH RFC 0/5] tipc: add support for TIPC over InfiniBand Patrick McHardy
2013-04-03 12:43 ` [PATCH 2/5] tipc: move bcast_addr from struct tipc_media to struct tipc_bearer Patrick McHardy
[not found] ` <1364993010-15515-1-git-send-email-kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2013-04-03 12:43 ` [PATCH 1/5] tipc: remove unused str2addr media callback Patrick McHardy
2013-04-03 12:43 ` [PATCH 3/5] tipc: set skb->protocol in eth_media packet transmission Patrick McHardy
2013-04-03 12:43 ` [PATCH 4/5] tipc: add InfiniBand media type Patrick McHardy
2013-04-03 14:41 ` Erik Hugne
2013-04-03 14:49 ` Patrick McHardy
[not found] ` <1364993010-15515-5-git-send-email-kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2013-04-07 9:07 ` Ying Xue
2013-04-07 9:07 ` Ying Xue
[not found] ` <51613740.6050501-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2013-04-07 12:04 ` Patrick McHardy
2013-04-07 9:19 ` Bart Van Assche
2013-04-07 9:43 ` Patrick McHardy [this message]
2013-04-03 12:43 ` [PATCH 5/5] IPoIB: add support for TIPC protocol Patrick McHardy
[not found] ` <1364993010-15515-6-git-send-email-kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2013-04-03 15:31 ` Or Gerlitz
2013-04-03 15:31 ` Or Gerlitz
2013-04-03 15:44 ` Patrick McHardy
2013-04-03 19:44 ` [PATCH RFC 0/5] tipc: add support for TIPC over InfiniBand Jon Maloy
2013-04-03 19:44 ` Jon Maloy
-- strict thread matches above, loose matches on Subject: below --
2013-04-17 16:18 [PATCH v2 0/5] tipc: add TIPC over Infiniband support Patrick McHardy
2013-04-17 16:18 ` [PATCH 4/5] tipc: add InfiniBand media type Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130407094345.GA24908@macbook.localnet \
--to=kaber@trash.net \
--cc=allan.stephens@windriver.com \
--cc=bvanassche@acm.org \
--cc=hal.rosenstock@gmail.com \
--cc=jon.maloy@ericsson.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.