From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Nishanth Menon <nm@ti.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Greg Guyotte <gguyotte@ti.com>,
lkml <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: regulator: query on regulator re-entrance
Date: Fri, 5 Apr 2013 10:44:12 +0100 [thread overview]
Message-ID: <20130405094411.GA6597@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1365138582-10409-1-git-send-email-nm@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 971 bytes --]
On Fri, Apr 05, 2013 at 12:09:42AM -0500, Nishanth Menon wrote:
> If we ignore the details of the class 1.5 implementation, we will notice
> a) regulator set_voltage equivalent set_voltage() is required.
> b) this set_voltage does some 'magic stuff' depending on the SoC and AVS class
> and calls the 'real regulator' which talks to the PMIC over i2c/spi etc..
> in short the call sequence is more or less:
>
> driver (cpufreq) -> AVS -> PMIC regulator.
>
> By modeling AVS class drivers as an regulator, we then do not need to introduce
> SoC specific hacks and APIs.
But you're shoehorning something into the regulator API which isn't
supposed to be there and causing yourself problems. This just isn't a
good idea. The regulator API already has a mechanism for supporting
regulators which are supplied by other regulators, if you can't model in
terms of that (adding something to support variability better) then
you're not using a regulator.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: regulator: query on regulator re-entrance
Date: Fri, 5 Apr 2013 10:44:12 +0100 [thread overview]
Message-ID: <20130405094411.GA6597@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1365138582-10409-1-git-send-email-nm@ti.com>
On Fri, Apr 05, 2013 at 12:09:42AM -0500, Nishanth Menon wrote:
> If we ignore the details of the class 1.5 implementation, we will notice
> a) regulator set_voltage equivalent set_voltage() is required.
> b) this set_voltage does some 'magic stuff' depending on the SoC and AVS class
> and calls the 'real regulator' which talks to the PMIC over i2c/spi etc..
> in short the call sequence is more or less:
>
> driver (cpufreq) -> AVS -> PMIC regulator.
>
> By modeling AVS class drivers as an regulator, we then do not need to introduce
> SoC specific hacks and APIs.
But you're shoehorning something into the regulator API which isn't
supposed to be there and causing yourself problems. This just isn't a
good idea. The regulator API already has a mechanism for supporting
regulators which are supplied by other regulators, if you can't model in
terms of that (adding something to support variability better) then
you're not using a regulator.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130405/1d9819c6/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Nishanth Menon <nm@ti.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Greg Guyotte <gguyotte@ti.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: regulator: query on regulator re-entrance
Date: Fri, 5 Apr 2013 10:44:12 +0100 [thread overview]
Message-ID: <20130405094411.GA6597@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1365138582-10409-1-git-send-email-nm@ti.com>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On Fri, Apr 05, 2013 at 12:09:42AM -0500, Nishanth Menon wrote:
> If we ignore the details of the class 1.5 implementation, we will notice
> a) regulator set_voltage equivalent set_voltage() is required.
> b) this set_voltage does some 'magic stuff' depending on the SoC and AVS class
> and calls the 'real regulator' which talks to the PMIC over i2c/spi etc..
> in short the call sequence is more or less:
>
> driver (cpufreq) -> AVS -> PMIC regulator.
>
> By modeling AVS class drivers as an regulator, we then do not need to introduce
> SoC specific hacks and APIs.
But you're shoehorning something into the regulator API which isn't
supposed to be there and causing yourself problems. This just isn't a
good idea. The regulator API already has a mechanism for supporting
regulators which are supplied by other regulators, if you can't model in
terms of that (adding something to support variability better) then
you're not using a regulator.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-05 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 5:09 regulator: query on regulator re-entrance Nishanth Menon
2013-04-05 5:09 ` Nishanth Menon
2013-04-05 9:44 ` Mark Brown [this message]
2013-04-05 9:44 ` Mark Brown
2013-04-05 9:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405094411.GA6597@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gguyotte@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.