Re: [PATCH] 30_os-prober: add $onstr ot top level Linux entries too

[Andrey Borzenkov <arvidjaar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

В Sat, 06 Apr 2013 21:39:24 +0200
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:

> On 05.04.2013 09:30, Andrey Borzenkov wrote:
> 
> > This fixes two issues
> > 
> > 1. It visually distinguishes between multiple installations of the
> > same OS version. Currently all of them get identical titles.
> > 
> 
> I don't know how "speaking" the device names are in practice. They are
> not stable and what is sda1 under one install can be sdb1 under another
> one. Perhaps we should use some other kind of identifier for this.
> 

Well,

a) those names are from the perspective of a single installation only.
In this respect it does not matter how another install calls it.

b) this is already used for some of menu entries. So it is just to
establish consistency. If something better is invented, I am fine with
it, but current situation is inconsistent.

> > 2. linux prober is using "(on /dev/xxx)" as indication that entry has
> > to be skipped. Top level entries should be skipped too.
> 
> This is improper. This string can be translated and e.g. '(на /dev/xxx)'
> or '(auf /dev/xxx)' won't match '(on /dev/xxx)'. "$menuentry_id_option
> 'osprober-" should be used instead (and (on ...) be kept in or-way for
> backward compatibility).
> 

Ah. Did not occur to me, thank you for idea! 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]