From: Calvin Owens <jcalvinowens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: jcalvinowens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Fwd: [PATCH] nouveau: Fix unconditional return waiting on memory
Date: Sun, 7 Apr 2013 21:01:19 -0500 [thread overview]
Message-ID: <20130408020117.GA6479@gmail.com> (raw)
----- Forwarded message from Calvin Owens <jcalvinowens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> -----
From: Calvin Owens <jcalvinowens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
CC: Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Calvin Owens <jcalvinowens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Thu, 21 Mar 2013 13:10:12 -0500
Subject: [PATCH] nouveau: Fix unconditional return waiting on memory
Typo in nv50_display_flip_wait allows page flipping to run ahead before
memory has time to settle.
Signed-off-by: Calvin Owens <jcalvinowens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/gpu/drm/nouveau/nv50_display.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
index 2db5799..96bc2f3 100644
--- a/drivers/gpu/drm/nouveau/nv50_display.c
+++ b/drivers/gpu/drm/nouveau/nv50_display.c
@@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
{
struct nv50_display_flip *flip = data;
if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
- flip->chan->data);
+ flip->chan->data)
return true;
usleep_range(1, 2);
return false;
--
1.7.3.4
----- End forwarded message -----
next reply other threads:[~2013-04-08 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 2:01 Calvin Owens [this message]
[not found] ` <20130408020117.GA6479-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-08 22:42 ` Fwd: [PATCH] nouveau: Fix unconditional return waiting on memory Marcin Ślusarz
[not found] ` <CA+GA0_tm86Z7H6mGi056BhWrq2=+_69N3Xcn3HUCa_hQuB_Wqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-09 7:04 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408020117.GA6479@gmail.com \
--to=jcalvinowens-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.