Fwd: [PATCH] nouveau: Fix unconditional return waiting on memory

Fwd: [PATCH] nouveau: Fix unconditional return waiting on memory

[Calvin Owens]

----- Forwarded message from Calvin Owens <jcalvinowens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> -----

From: Calvin Owens <jcalvinowens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
CC: Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, Calvin Owens <jcalvinowens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Thu, 21 Mar 2013 13:10:12 -0500
Subject: [PATCH] nouveau: Fix unconditional return waiting on memory

Typo in nv50_display_flip_wait allows page flipping to run ahead before
memory has time to settle.

Signed-off-by: Calvin Owens <jcalvinowens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/gpu/drm/nouveau/nv50_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
index 2db5799..96bc2f3 100644
--- a/drivers/gpu/drm/nouveau/nv50_display.c
+++ b/drivers/gpu/drm/nouveau/nv50_display.c
@@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
 {
 	struct nv50_display_flip *flip = data;
 	if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
-					      flip->chan->data);
+					      flip->chan->data)
 		return true;
 	usleep_range(1, 2);
 	return false;
-- 
1.7.3.4

----- End forwarded message -----

Re: Fwd: [PATCH] nouveau: Fix unconditional return waiting on memory

[Marcin Ślusarz]

[-- Attachment #1.1: Type: text/plain, Size: 183 bytes --]

This is ridiculous. If such trivial bugfixes need to be reposted so many
times, what does it say about the maintainer? Can we have a real one?

Frustrated for the *n-th* time,
Marcin

[-- Attachment #1.2: Type: text/html, Size: 200 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: Fwd: [PATCH] nouveau: Fix unconditional return waiting on memory

[Dave Airlie]

> 
> This is ridiculous. If such trivial bugfixes need to be reposted so many
> times, what does it say about the maintainer? Can we have a real one?
> 

This isn't a trivial bugfix though, if it was I'd have just merged it

When mistakes like that happen, fixing them can sometimes end causing 
wierd regressions, so don't think just because it one semicolon that it 
has only a trivial effect or needs no testing.

Dave.