* [PATCH] printk: fix failure to return error in devkmsg_poll
@ 2013-04-08 10:18 Nicolas Kaiser
0 siblings, 0 replies; only message in thread
From: Nicolas Kaiser @ 2013-04-08 10:18 UTC (permalink / raw)
To: Kay Sievers; +Cc: linux-kernel
Error value got overwritten instantly.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
kernel/printk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/printk.c b/kernel/printk.c
index abbdd9e..6317194 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -608,7 +608,8 @@ static unsigned int devkmsg_poll(struct file *file, poll_table *wait)
/* return error when data has vanished underneath us */
if (user->seq < log_first_seq)
ret = POLLIN|POLLRDNORM|POLLERR|POLLPRI;
- ret = POLLIN|POLLRDNORM;
+ else
+ ret = POLLIN|POLLRDNORM;
}
raw_spin_unlock_irq(&logbuf_lock);
--
1.8.1.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-04-08 10:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-08 10:18 [PATCH] printk: fix failure to return error in devkmsg_poll Nicolas Kaiser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.