All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: move vhost-net to config-host.mak
Date: Tue, 9 Apr 2013 14:16:30 +0300	[thread overview]
Message-ID: <20130409111630.GB27374@redhat.com> (raw)
In-Reply-To: <1365503248-21275-1-git-send-email-pbonzini@redhat.com>

On Tue, Apr 09, 2013 at 12:27:28PM +0200, Paolo Bonzini wrote:
> There is no reason why vhost-net should not work with TCG.
> Hence, put the limitation in hw/vhost-net.c, not straight in
> the config-*.mak files.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

If you want to enable vhost for tcg why not enable it, and fix
any fallout?

> ---
>  configure          | 6 +++---
>  hw/net/vhost_net.c | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/configure b/configure
> index d5f2918..4b4b19e 100755
> --- a/configure
> +++ b/configure
> @@ -3686,6 +3686,9 @@ fi
>  if test "$virtfs" = "yes" ; then
>    echo "CONFIG_VIRTFS=y" >> $config_host_mak
>  fi
> +if test "$vhost_net" = "yes" ; then
> +  echo "CONFIG_VHOST_NET=y" >> $config_host_mak
> +fi
>  if test "$blobs" = "yes" ; then
>    echo "INSTALL_BLOBS=yes" >> $config_host_mak
>  fi
> @@ -4152,9 +4155,6 @@ case "$target_arch2" in
>        \( "$target_arch2" = "x86_64" -a "$cpu" = "i386"   \) -o \
>        \( "$target_arch2" = "i386"   -a "$cpu" = "x86_64" \) \) ; then
>        echo "CONFIG_KVM=y" >> $config_target_mak
> -      if test "$vhost_net" = "yes" ; then
> -        echo "CONFIG_VHOST_NET=y" >> $config_target_mak
> -      fi
>      fi
>  esac
>  case "$target_arch2" in
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 8c5384c..0956843 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -22,7 +22,7 @@
>  
>  #include "config.h"
>  
> -#ifdef CONFIG_VHOST_NET
> +#if defined CONFIG_LINUX && defined CONFIG_VHOST_NET && defined CONFIG_KVM
>  #include <linux/vhost.h>
>  #include <sys/socket.h>
>  #include <linux/kvm.h>
> -- 
> 1.8.1.4

  reply	other threads:[~2013-04-09 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 10:27 [Qemu-devel] [PATCH] configure: move vhost-net to config-host.mak Paolo Bonzini
2013-04-09 11:16 ` Michael S. Tsirkin [this message]
2013-04-09 14:33   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130409111630.GB27374@redhat.com \
    --to=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.