All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: move vhost-net to config-host.mak
Date: Tue, 09 Apr 2013 16:33:24 +0200	[thread overview]
Message-ID: <516426B4.6070701@redhat.com> (raw)
In-Reply-To: <20130409111630.GB27374@redhat.com>

Il 09/04/2013 13:16, Michael S. Tsirkin ha scritto:
>> > There is no reason why vhost-net should not work with TCG.
>> > Hence, put the limitation in hw/vhost-net.c, not straight in
>> > the config-*.mak files.
>> > 
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> If you want to enable vhost for tcg why not enable it,

Actually, vhost is already enabled for TCG, and doesn't work because
nothing triggers the host notifiers.  I thought there was an "if
(kvm_enabled())" somewhere, but there isn't.  It is not enabled for
TCG-only targets, which makes even less sense...

> and fix any fallout?

I don't want to enable vhost for TCG.  What I want to do is limit
config-target.mak to things that are really target-dependent.

Anyway, I found an old patch from Stefan to fix vhost with TCG.  When
I'll have time I'll submit both.  Scrap this patch for now.

Paolo

      reply	other threads:[~2013-04-09 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 10:27 [Qemu-devel] [PATCH] configure: move vhost-net to config-host.mak Paolo Bonzini
2013-04-09 11:16 ` Michael S. Tsirkin
2013-04-09 14:33   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516426B4.6070701@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.