All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][meta-systemd][danny][PATCH] cloud9: add EnvironmentFile
Date: Wed, 10 Apr 2013 18:17:00 +0200	[thread overview]
Message-ID: <20130410161700.GE2471@jama> (raw)
In-Reply-To: <kk42oq$o6t$1@ger.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

On Wed, Apr 10, 2013 at 06:07:59PM +0200, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Op 08-04-13 09:57, Jason Kridner schreef:
> > * Allows specification of NODE_PATH
> > 
> > Signed-off-by: Jason Kridner <jdk@ti.com> --- 
> > .../recipes-devtools/cloud9/cloud9/cloud9.service  |    1 + 1 files
> > changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git
> > a/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service
> > b/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service 
> > index 714b465..54a9db0 100644 ---
> > a/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service +++
> > b/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service @@
> > -3,6 +3,7 @@ Description=Cloud9 IDE ConditionPathExists=|/var/lib/cloud9
> > 
> > [Service] +EnvironmentFile=-/etc/conf.d/node ExecStart=/usr/bin/node4
> > /usr/share/cloud9/bin/cloud9.js -l 0.0.0.0 -w /var/lib/cloud9 -p 3000
> > 
> > [Install]
> > 
> 
> 
> It's a bit late now, but this shouldn't go in, it introduces a gentoo-ism
> (/etc/conf.d) that we don't want.

Ah, sorry about that.

> Martin, can you revert it please?

Sure

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
> 
> iD8DBQFRZY5fMkyGM64RGpERAsUrAKCpirNbZj9g6fdigv2+GZUqSksGVQCeJths
> zlp4sG6jcgBF1RjzikHwksw=
> =6TFx
> -----END PGP SIGNATURE-----
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  reply	other threads:[~2013-04-10 16:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  7:57 [meta-oe][meta-systemd][danny][PATCH] cloud9: add EnvironmentFile Jason Kridner
2013-04-10 16:07 ` Koen Kooi
2013-04-10 16:17   ` Martin Jansa [this message]
2013-04-10 16:23     ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130410161700.GE2471@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.