Re: [meta-oe][meta-systemd][danny][PATCH] cloud9: add EnvironmentFile

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 10-04-13 18:17, Martin Jansa schreef:
> On Wed, Apr 10, 2013 at 06:07:59PM +0200, Koen Kooi wrote: Op 08-04-13
> 09:57, Jason Kridner schreef:
>>>> * Allows specification of NODE_PATH
>>>> 
>>>> Signed-off-by: Jason Kridner <jdk@ti.com> --- 
>>>> .../recipes-devtools/cloud9/cloud9/cloud9.service  |    1 + 1
>>>> files changed, 1 insertions(+), 0 deletions(-)
>>>> 
>>>> diff --git 
>>>> a/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service
>>>>
>>>> 
b/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service
>>>> index 714b465..54a9db0 100644 --- 
>>>> a/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service
>>>> +++ 
>>>> b/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service
>>>> @@ -3,6 +3,7 @@ Description=Cloud9 IDE
>>>> ConditionPathExists=|/var/lib/cloud9
>>>> 
>>>> [Service] +EnvironmentFile=-/etc/conf.d/node
>>>> ExecStart=/usr/bin/node4 /usr/share/cloud9/bin/cloud9.js -l 0.0.0.0
>>>> -w /var/lib/cloud9 -p 3000
>>>> 
>>>> [Install]
>>>> 
> 
> 
> It's a bit late now, but this shouldn't go in, it introduces a
> gentoo-ism (/etc/conf.d) that we don't want.
> 
>> Ah, sorry about that.
> 
> Martin, can you revert it please?

Or have a look at the 8 patches I sent, the revert is part of that :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFRZZIZMkyGM64RGpERAjvsAJ9IyCRx7u+PHUOFMxCtOpilopAynwCffAIL
8njlZ3JTh//ARcoaPaJIdpQ=
=j6Do
-----END PGP SIGNATURE-----