* [Qemu-trivial] [PATCH] qapi: use valid JSON in schema
@ 2013-04-10 19:12 ` Eric Blake
0 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2013-04-10 19:12 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, qemu-trivial, lcapitulino
* qapi-schema.json: JSON doesn't allow trailing commas.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
a multi-line regex search for ',[ \n]*[]}]' didn't turn up any
other violations
qapi-schema.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index db542f6..044517d 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1600,7 +1600,7 @@
##
{ 'union': 'BlockdevAction',
'data': {
- 'blockdev-snapshot-sync': 'BlockdevSnapshot',
+ 'blockdev-snapshot-sync': 'BlockdevSnapshot'
} }
##
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] qapi: use valid JSON in schema
@ 2013-04-10 19:12 ` Eric Blake
0 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2013-04-10 19:12 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, qemu-trivial, lcapitulino
* qapi-schema.json: JSON doesn't allow trailing commas.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
a multi-line regex search for ',[ \n]*[]}]' didn't turn up any
other violations
qapi-schema.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index db542f6..044517d 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1600,7 +1600,7 @@
##
{ 'union': 'BlockdevAction',
'data': {
- 'blockdev-snapshot-sync': 'BlockdevSnapshot',
+ 'blockdev-snapshot-sync': 'BlockdevSnapshot'
} }
##
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [PATCH] qapi: use valid JSON in schema
2013-04-10 19:12 ` [Qemu-devel] " Eric Blake
@ 2013-04-11 12:50 ` Luiz Capitulino
-1 siblings, 0 replies; 4+ messages in thread
From: Luiz Capitulino @ 2013-04-11 12:50 UTC (permalink / raw)
To: Eric Blake; +Cc: kwolf, qemu-trivial, qemu-devel
On Wed, 10 Apr 2013 13:12:44 -0600
Eric Blake <eblake@redhat.com> wrote:
> * qapi-schema.json: JSON doesn't allow trailing commas.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Applied to the qmp branch, thanks.
> ---
>
> a multi-line regex search for ',[ \n]*[]}]' didn't turn up any
> other violations
>
> qapi-schema.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index db542f6..044517d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1600,7 +1600,7 @@
> ##
> { 'union': 'BlockdevAction',
> 'data': {
> - 'blockdev-snapshot-sync': 'BlockdevSnapshot',
> + 'blockdev-snapshot-sync': 'BlockdevSnapshot'
> } }
>
> ##
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qapi: use valid JSON in schema
@ 2013-04-11 12:50 ` Luiz Capitulino
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Capitulino @ 2013-04-11 12:50 UTC (permalink / raw)
To: Eric Blake; +Cc: kwolf, qemu-trivial, qemu-devel
On Wed, 10 Apr 2013 13:12:44 -0600
Eric Blake <eblake@redhat.com> wrote:
> * qapi-schema.json: JSON doesn't allow trailing commas.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Applied to the qmp branch, thanks.
> ---
>
> a multi-line regex search for ',[ \n]*[]}]' didn't turn up any
> other violations
>
> qapi-schema.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index db542f6..044517d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1600,7 +1600,7 @@
> ##
> { 'union': 'BlockdevAction',
> 'data': {
> - 'blockdev-snapshot-sync': 'BlockdevSnapshot',
> + 'blockdev-snapshot-sync': 'BlockdevSnapshot'
> } }
>
> ##
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-11 12:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-10 19:12 [Qemu-trivial] [PATCH] qapi: use valid JSON in schema Eric Blake
2013-04-10 19:12 ` [Qemu-devel] " Eric Blake
2013-04-11 12:50 ` [Qemu-trivial] " Luiz Capitulino
2013-04-11 12:50 ` [Qemu-devel] " Luiz Capitulino
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.