Re: [PATCH 02/10] staging: zcache: remove zcache_freeze

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Apr 11, 2013 at 10:13:42AM -0700, Dan Magenheimer wrote:
> > From: Wanpeng Li [mailto:liwanp@linux.vnet.ibm.com]
> > Subject: [PATCH 02/10] staging: zcache: remove zcache_freeze
> > 
> > The default value of zcache_freeze is false and it won't be modified by
> > other codes. Remove zcache_freeze since no routine can disable zcache
> > during system running.
> > 
> > Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
> 
> I'd prefer to leave this code in place as it may be very useful
> if/when zcache becomes more tightly integrated into the MM subsystem
> and the rest of the kernel.  And the subtleties for temporarily disabling
> zcache (which is what zcache_freeze does) are non-obvious and
> may cause data loss so if someone wants to add this functionality
> back in later and don't have this piece of code, it may take
> a lot of pain to get it working.
> 
> Usage example: All CPUs are fully saturated so it is questionable
> whether spending CPU cycles for compression is wise.  Kernel
> could disable zcache using zcache_freeze.  (Yes, a new entry point
> would need to be added to enable/disable zcache_freeze.)
> 
> My two cents... others are welcome to override.

I will not override, and did not take this patch.

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>