From: Arnd Bergmann <arnd@arndb.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Chanho Park <chanho61.park@samsung.com>,
Tushar Behera <tushar.behera@linaro.org>,
Tomasz Figa <t.figa@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 3/7] ARM: exynos: add missing properties for combiner IRQs
Date: Mon, 15 Apr 2013 14:20:35 +0200 [thread overview]
Message-ID: <201304151420.35843.arnd@arndb.de> (raw)
In-Reply-To: <CAK9yfHwXYRqo2yG1moWvMnEmNWXCVL7a9eKzi2we=QmdpVsz-w@mail.gmail.com>
On Monday 15 April 2013, Sachin Kamat wrote:
> >> > diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> >> > index 36d4299..f83c3c1 100644
> >> > --- a/arch/arm/boot/dts/exynos4212.dtsi
> >> > +++ b/arch/arm/boot/dts/exynos4212.dtsi
> >> > @@ -26,6 +26,15 @@
> >> > cpu-offset = <0x8000>;
> >> > };
> >> >
> >> > + interrupt-controller@10440000 {
> >>
> >> Don't we need a node name here (combiner:interrupt-controller@10440000)?
> >
> > Why?
>
> Since it is being referenced as "&combiner" by other bindings, i
> thought that was required.
The original definition actually comes from exynos4.dtsi. It's enough
to have the label in one place.
> >> We have a combiner node defined in exynos4x12.dtsi. With the bindings
> >> now defined separately in 4212 and 4412 dtsi files, probably the one
> >> in 4x12 could be dropped?
> >
> > I did not see that one, but it seems to have the wrong numbers in the last
> > four interrupt specifiers. I think it would be better to just fix that one
> > and keep using it.
>
> OK. Do you want me to fix it and send as a patch or would you like to do it?
If you have a patch that works, you could just send it out, oetherwise I'd
do it.
ARnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] ARM: exynos: add missing properties for combiner IRQs
Date: Mon, 15 Apr 2013 14:20:35 +0200 [thread overview]
Message-ID: <201304151420.35843.arnd@arndb.de> (raw)
In-Reply-To: <CAK9yfHwXYRqo2yG1moWvMnEmNWXCVL7a9eKzi2we=QmdpVsz-w@mail.gmail.com>
On Monday 15 April 2013, Sachin Kamat wrote:
> >> > diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
> >> > index 36d4299..f83c3c1 100644
> >> > --- a/arch/arm/boot/dts/exynos4212.dtsi
> >> > +++ b/arch/arm/boot/dts/exynos4212.dtsi
> >> > @@ -26,6 +26,15 @@
> >> > cpu-offset = <0x8000>;
> >> > };
> >> >
> >> > + interrupt-controller at 10440000 {
> >>
> >> Don't we need a node name here (combiner:interrupt-controller at 10440000)?
> >
> > Why?
>
> Since it is being referenced as "&combiner" by other bindings, i
> thought that was required.
The original definition actually comes from exynos4.dtsi. It's enough
to have the label in one place.
> >> We have a combiner node defined in exynos4x12.dtsi. With the bindings
> >> now defined separately in 4212 and 4412 dtsi files, probably the one
> >> in 4x12 could be dropped?
> >
> > I did not see that one, but it seems to have the wrong numbers in the last
> > four interrupt specifiers. I think it would be better to just fix that one
> > and keep using it.
>
> OK. Do you want me to fix it and send as a patch or would you like to do it?
If you have a patch that works, you could just send it out, oetherwise I'd
do it.
ARnd
next prev parent reply other threads:[~2013-04-15 12:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 14:03 [PATCH 0/7] exynos multiplatform support, part 2 Arnd Bergmann
2013-04-12 14:03 ` Arnd Bergmann
2013-04-12 14:03 ` [PATCH 1/7] clk: exynos: prepare for multiplatform Arnd Bergmann
2013-04-12 14:03 ` Arnd Bergmann
2013-04-15 6:31 ` Thomas Abraham
2013-04-15 6:31 ` Thomas Abraham
2013-04-15 8:35 ` Arnd Bergmann
2013-04-15 8:35 ` Arnd Bergmann
2013-04-15 17:20 ` Sylwester Nawrocki
2013-04-15 17:20 ` Sylwester Nawrocki
2013-04-12 14:03 ` [PATCH 2/7] clocksource: exynos_mct: remove platform header dependency Arnd Bergmann
2013-04-12 14:03 ` Arnd Bergmann
2013-04-12 14:03 ` [PATCH 3/7] ARM: exynos: add missing properties for combiner IRQs Arnd Bergmann
2013-04-12 14:03 ` Arnd Bergmann
2013-04-15 6:27 ` Thomas Abraham
2013-04-15 6:27 ` Thomas Abraham
2013-04-15 8:36 ` Arnd Bergmann
2013-04-15 8:36 ` Arnd Bergmann
2013-04-15 6:43 ` Sachin Kamat
2013-04-15 6:43 ` Sachin Kamat
2013-04-15 8:41 ` Arnd Bergmann
2013-04-15 8:41 ` Arnd Bergmann
2013-04-15 11:32 ` Sachin Kamat
2013-04-15 11:32 ` Sachin Kamat
2013-04-15 12:20 ` Arnd Bergmann [this message]
2013-04-15 12:20 ` Arnd Bergmann
2013-04-15 12:45 ` Sachin Kamat
2013-04-15 12:45 ` Sachin Kamat
2013-04-12 14:03 ` [PATCH 4/7] irqchip: exynos: pass max combiner number to combiner_init Arnd Bergmann
2013-04-12 14:03 ` Arnd Bergmann
2013-04-12 14:03 ` [PATCH 5/7] irqchip: exynos: allocate combiner_data dynamically Arnd Bergmann
2013-04-12 14:03 ` Arnd Bergmann
2013-04-12 14:03 ` [PATCH 6/7] irqchip: exynos: localize irq lookup for ATAGS Arnd Bergmann
2013-04-12 14:03 ` Arnd Bergmann
2013-04-12 14:03 ` [PATCH 7/7] irqchip: exynos: pass irq_base from platform Arnd Bergmann
2013-04-12 14:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304151420.35843.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=chanho61.park@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.