Proposed bindings for a GPIO watchdog drivers

Proposed bindings for a GPIO watchdog drivers

[Alexander Morozov]

Hello,

I've written a watchdog driver for simple chips that are connected via
GPIO. Driver can be used with chips from different manufacturers.
Should "compatible" property be set to "gpio-wdt" or
"generic,gpio-wdt"? Are there any other problems with following
bindings?

---------

Required properties:
- compatible: must be "generic,gpio-wdt".
- gpios: gpio pin to use
- ping-sec: how often to ping the watchdog before userspace watchdog
daemon is started,
- timeout-sec: watchdog timeout that is reported to userspace.

Example:

max6369 {
        compatible = "generic,gpio-wdt";
        gpios = <&pioB 13 0>;
        ping-sec = <5>;
        timeout-sec = <60>;
};

Regards,
Alexander Morozov.

Re: Proposed bindings for a GPIO watchdog drivers

[Grant Likely]

On Tue, 26 Mar 2013 20:04:30 +0400, Alexander Morozov <etesial-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hello,
> 
> I've written a watchdog driver for simple chips that are connected via
> GPIO. Driver can be used with chips from different manufacturers.
> Should "compatible" property be set to "gpio-wdt" or
> "generic,gpio-wdt"? Are there any other problems with following
> bindings?

The trick with things like 'simple' gpio connections are that they may
not be very simple at all, and there are many different ways that the
interface can be designed to work. The most important thing here is that
you document exactly the protocol used by this hardware. So, not just
that is uses a GPIO pin, but /how/ the gpio pin is used. Is it a pulse?
Is it edge or level sensitive? etc.

g.

> 
> ---------
> 
> Required properties:
> - compatible: must be "generic,gpio-wdt".
> - gpios: gpio pin to use
> - ping-sec: how often to ping the watchdog before userspace watchdog
> daemon is started,
> - timeout-sec: watchdog timeout that is reported to userspace.
> 
> Example:
> 
> max6369 {
>         compatible = "generic,gpio-wdt";
>         gpios = <&pioB 13 0>;
>         ping-sec = <5>;
>         timeout-sec = <60>;
> };
> 
> Regards,
> Alexander Morozov.
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.