* [PATCH] ASoC: max98088: Fix logging of hardware revision.
@ 2013-04-17 3:02 Dylan Reid
2013-04-17 13:33 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Dylan Reid @ 2013-04-17 3:02 UTC (permalink / raw)
To: alsa-devel; +Cc: Dylan Reid, broonie, lgirdwood
The hardware revision of the codec is based at 0x40. Subtract that
before convering to ASCII. The same as it is done for 98095.
Signed-off-by: Dylan Reid <dgreid@chromium.org>
---
sound/soc/codecs/max98088.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
index 3a7b7fd..3eeada5 100644
--- a/sound/soc/codecs/max98088.c
+++ b/sound/soc/codecs/max98088.c
@@ -2024,7 +2024,7 @@ static int max98088_probe(struct snd_soc_codec *codec)
ret);
goto err_access;
}
- dev_info(codec->dev, "revision %c\n", ret + 'A');
+ dev_info(codec->dev, "revision %c\n", ret - 0x40 + 'A');
snd_soc_write(codec, M98088_REG_51_PWR_SYS, M98088_PWRSV);
--
1.8.1.3.605.g02339dd
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: max98088: Fix logging of hardware revision.
2013-04-17 3:02 [PATCH] ASoC: max98088: Fix logging of hardware revision Dylan Reid
@ 2013-04-17 13:33 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-04-17 13:33 UTC (permalink / raw)
To: Dylan Reid; +Cc: alsa-devel, lgirdwood
[-- Attachment #1.1: Type: text/plain, Size: 258 bytes --]
On Tue, Apr 16, 2013 at 08:02:34PM -0700, Dylan Reid wrote:
> The hardware revision of the codec is based at 0x40. Subtract that
> before convering to ASCII. The same as it is done for 98095.
Wow, someone had fun defining that... applied anyway, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-17 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-17 3:02 [PATCH] ASoC: max98088: Fix logging of hardware revision Dylan Reid
2013-04-17 13:33 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.