From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915: Disable primary plane trickle feed for g4x
Date: Wed, 17 Apr 2013 20:46:48 +0300 [thread overview]
Message-ID: <20130417174647.GP4469@intel.com> (raw)
In-Reply-To: <20130417172529.GE24068@cantiga.alporthouse.com>
On Wed, Apr 17, 2013 at 06:25:29PM +0100, Chris Wilson wrote:
> On Wed, Apr 17, 2013 at 08:11:58PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The docs say that the trickle feed disable bit is present (for primary
> > planes only, not video sprites) on BLC and CTG, and that it must be set
> > for ELK. Just set it for all g4x chipset.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I'm stunned that we did all the post-pch chipsets but missed g4x.
> Perhaps we should also do it during init_clock_gating() as we do for
> other generations?
Actually we do it in both ironlake_update_plane() and
init_clock_gating() for gen5+. I guess someone wanted to make sure
the bit sticks ;)
I'm thinking I'd rather kill the init_clock_gating() parts since that
would keep the whole plane setup in one place.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-04-17 17:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 17:11 [PATCH 1/4] drm/i915: Disable primary plane trickle feed for g4x ville.syrjala
2013-04-17 17:11 ` [PATCH 2/4] drm/i915: Clarify DSPPOS/DSPSIZE and pipe selection for planes A/B ville.syrjala
2013-04-17 17:12 ` [PATCH 3/4] drm/i915: Sprite C support for Gen4 and earlier ville.syrjala
2013-04-17 17:12 ` [PATCH 4/4] drm/i915: Use ILK+ style video sprites for Gen4.5 ville.syrjala
2013-04-17 17:25 ` [PATCH 1/4] drm/i915: Disable primary plane trickle feed for g4x Chris Wilson
2013-04-17 17:46 ` Ville Syrjälä [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-07 7:47 [PATCH 0/4] drm/i915: Trickle feed bits v2 ville.syrjala
2013-06-07 7:47 ` [PATCH 1/4] drm/i915: Disable primary plane trickle feed for g4x ville.syrjala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130417174647.GP4469@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.