All of lore.kernel.org
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM64: kernel: compiling issue: need define readq and writeq for driver module using.
Date: Fri, 19 Apr 2013 13:35:13 +0100	[thread overview]
Message-ID: <20130419123513.GB18443@arm.com> (raw)
In-Reply-To: <51712975.8030104@asianux.com>

On Fri, Apr 19, 2013 at 12:24:37PM +0100, Chen Gang wrote:
> 
>   when compiling with allmodconfig, CONFIG_64BIT=y
>     the file drivers/base/regmap/regmap-mmio.c will use readq and writeq.
> 
>   so we need implement these functions.
> 
> BTW:
>   the coding style can not pass ./scripts/checkpatch.pl.
>   it seems better to provide additional patch for beautifying code.

If it complains about long lines, just ignore it. I wouldn't worry too
much about checkpatch.pl and coding style warnings ;)

> Signed-off-by: Chen Gang <gang.chen@asianux.com>

Thanks.

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Will Deacon <Will.Deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
	Tony Lindgren <tony@atomide.com>,
	"olof@lixom.net" <olof@lixom.net>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM64: kernel: compiling issue: need define readq and writeq for driver module using.
Date: Fri, 19 Apr 2013 13:35:13 +0100	[thread overview]
Message-ID: <20130419123513.GB18443@arm.com> (raw)
In-Reply-To: <51712975.8030104@asianux.com>

On Fri, Apr 19, 2013 at 12:24:37PM +0100, Chen Gang wrote:
> 
>   when compiling with allmodconfig, CONFIG_64BIT=y
>     the file drivers/base/regmap/regmap-mmio.c will use readq and writeq.
> 
>   so we need implement these functions.
> 
> BTW:
>   the coding style can not pass ./scripts/checkpatch.pl.
>   it seems better to provide additional patch for beautifying code.

If it complains about long lines, just ignore it. I wouldn't worry too
much about checkpatch.pl and coding style warnings ;)

> Signed-off-by: Chen Gang <gang.chen@asianux.com>

Thanks.

-- 
Catalin

  parent reply	other threads:[~2013-04-19 12:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19 11:24 [PATCH] ARM64: kernel: compiling issue: need define readq and writeq for driver module using Chen Gang
2013-04-19 11:24 ` Chen Gang
2013-04-19 12:13 ` Arnd Bergmann
2013-04-19 12:13   ` Arnd Bergmann
2013-04-20  2:48   ` Chen Gang F T
2013-04-20  2:48     ` Chen Gang F T
2013-04-19 12:35 ` Catalin Marinas [this message]
2013-04-19 12:35   ` Catalin Marinas
2013-04-20  1:54   ` Chen Gang
2013-04-20  1:54     ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130419123513.GB18443@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.