From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: samuel@sortiz.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] [IrDA]: small read past the end of array in debug code
Date: Sat, 20 Apr 2013 20:39:16 +0000 [thread overview]
Message-ID: <20130420203916.GA8936@mwanda> (raw)
In-Reply-To: <20130419.173329.1993060022855519678.davem@davemloft.net>
On Fri, Apr 19, 2013 at 05:33:29PM -0400, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Wed, 17 Apr 2013 10:10:38 +0300
>
> > The "reason" can come from skb->data[] and it hasn't been capped so it
> > can be from 0-255 instead of just 0-6. For example in irlmp_state_dtr()
> > the code does:
> >
> > reason = skb->data[3];
> > ...
> > irlmp_disconnect_indication(self, reason, skb);
> >
> > Also LMREASON has a couple other values which don't have entries in the
> > irlmp_reasons[] array. And 0xff is a valid reason as well which means
> > "unknown".
> >
> > So far as I can see we don't actually care about "reason" except for in
> > the debug code.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied but please put the subsystem prefix outside of [] which get
> stripped by git am and other tools. I fixed it up to be "irda: ".
>
Sorry about that. I won't do it again.
It's weird because the prefix was cut and pasted from an earlier
commit. Also [media] and [SCSI] use square brackets in their
subsystems. I tried some experiments with "git am" and you're right
that "git am" always strips out the square bracket stuff. Odd.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: samuel@sortiz.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] [IrDA]: small read past the end of array in debug code
Date: Sat, 20 Apr 2013 23:39:16 +0300 [thread overview]
Message-ID: <20130420203916.GA8936@mwanda> (raw)
In-Reply-To: <20130419.173329.1993060022855519678.davem@davemloft.net>
On Fri, Apr 19, 2013 at 05:33:29PM -0400, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Wed, 17 Apr 2013 10:10:38 +0300
>
> > The "reason" can come from skb->data[] and it hasn't been capped so it
> > can be from 0-255 instead of just 0-6. For example in irlmp_state_dtr()
> > the code does:
> >
> > reason = skb->data[3];
> > ...
> > irlmp_disconnect_indication(self, reason, skb);
> >
> > Also LMREASON has a couple other values which don't have entries in the
> > irlmp_reasons[] array. And 0xff is a valid reason as well which means
> > "unknown".
> >
> > So far as I can see we don't actually care about "reason" except for in
> > the debug code.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied but please put the subsystem prefix outside of [] which get
> stripped by git am and other tools. I fixed it up to be "irda: ".
>
Sorry about that. I won't do it again.
It's weird because the prefix was cut and pasted from an earlier
commit. Also [media] and [SCSI] use square brackets in their
subsystems. I tried some experiments with "git am" and you're right
that "git am" always strips out the square bracket stuff. Odd.
regards,
dan carpenter
next prev parent reply other threads:[~2013-04-20 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 7:10 [patch] [IrDA]: small read past the end of array in debug code Dan Carpenter
2013-04-17 7:10 ` Dan Carpenter
2013-04-19 21:33 ` David Miller
2013-04-19 21:33 ` David Miller
2013-04-20 20:39 ` Dan Carpenter [this message]
2013-04-20 20:39 ` Dan Carpenter
2013-04-22 18:02 ` Ben Hutchings
2013-04-22 18:02 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130420203916.GA8936@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.