From: "Jörn Engel" <joern@logfs.org>
To: Joe Perches <joe@perches.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Joern Engel <joern@lazybastard.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: Convert logging messages
Date: Mon, 22 Apr 2013 10:31:18 -0400 [thread overview]
Message-ID: <20130422143118.GA12908@logfs.org> (raw)
In-Reply-To: <1366396053.3901.40.camel@joe-AO722>
On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote:
> On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
> > On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
> > > }
> > > list_add(&dev->list, &blkmtd_device_list);
> > > - INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index,
> > > - dev->mtd.name + strlen("block2mtd: "),
> > > - dev->mtd.erasesize >> 10, dev->mtd.erasesize);
> > > + pr_info("mtd%d: [%s] erase_size = %dKiB [%d]\n",
> > > + dev->mtd.index,
> > > + dev->mtd.name + strlen("block2mtd: "),
> > > + dev->mtd.erasesize >> 10, dev->mtd.erasesize);
> >
> > I personally dislike the indent-to-braces style because it causes
> > unnecessary churn in patches like this.
>
> It comes from an automated emacs conversion.
Then please teach your emacs to be a better tool. I trust you are
smart enough to do that.
Jörn
--
He who knows that enough is enough will always have enough.
-- Lao Tsu
WARNING: multiple messages have this Message-ID (diff)
From: "Jörn Engel" <joern@logfs.org>
To: Joe Perches <joe@perches.com>
Cc: Joern Engel <joern@lazybastard.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: Convert logging messages
Date: Mon, 22 Apr 2013 10:31:18 -0400 [thread overview]
Message-ID: <20130422143118.GA12908@logfs.org> (raw)
In-Reply-To: <1366396053.3901.40.camel@joe-AO722>
On Fri, 19 April 2013 11:27:33 -0700, Joe Perches wrote:
> On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
> > On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
> > > }
> > > list_add(&dev->list, &blkmtd_device_list);
> > > - INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index,
> > > - dev->mtd.name + strlen("block2mtd: "),
> > > - dev->mtd.erasesize >> 10, dev->mtd.erasesize);
> > > + pr_info("mtd%d: [%s] erase_size = %dKiB [%d]\n",
> > > + dev->mtd.index,
> > > + dev->mtd.name + strlen("block2mtd: "),
> > > + dev->mtd.erasesize >> 10, dev->mtd.erasesize);
> >
> > I personally dislike the indent-to-braces style because it causes
> > unnecessary churn in patches like this.
>
> It comes from an automated emacs conversion.
Then please teach your emacs to be a better tool. I trust you are
smart enough to do that.
Jörn
--
He who knows that enough is enough will always have enough.
-- Lao Tsu
next prev parent reply other threads:[~2013-04-22 15:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 17:59 [PATCH] mtd: Convert logging messages Joe Perches
2013-04-19 17:59 ` Joe Perches
2013-04-19 16:55 ` Jörn Engel
2013-04-19 16:55 ` Jörn Engel
2013-04-19 18:27 ` Joe Perches
2013-04-19 18:27 ` Joe Perches
2013-04-22 14:31 ` Jörn Engel [this message]
2013-04-22 14:31 ` Jörn Engel
2013-04-23 17:59 ` Joe Perches
2013-04-23 17:59 ` Joe Perches
2013-04-23 16:51 ` Jörn Engel
2013-04-23 16:51 ` Jörn Engel
2013-04-23 20:01 ` Joe Perches
2013-04-23 20:01 ` Joe Perches
2013-05-13 7:58 ` Artem Bityutskiy
2013-05-13 7:58 ` Artem Bityutskiy
2013-05-13 13:21 ` Jörn Engel
2013-05-13 13:21 ` Jörn Engel
2013-05-13 7:59 ` Artem Bityutskiy
2013-05-13 7:59 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422143118.GA12908@logfs.org \
--to=joern@logfs.org \
--cc=dwmw2@infradead.org \
--cc=joe@perches.com \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.