From: Robin Holt <holt@sgi.com>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Robin Holt <holt@sgi.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
walter harms <wharms@bfs.de>
Subject: Re: [patch v2] gru: info leak in gru_get_config_info()
Date: Mon, 22 Apr 2013 16:41:18 +0000 [thread overview]
Message-ID: <20130422164118.GO3672@sgi.com> (raw)
In-Reply-To: <20130421173334.GA9023@sgi.com>
Acked-by: Robin Holt <holt@sgi.com>
On Sun, Apr 21, 2013 at 12:33:34PM -0500, Dimitri Sivanich wrote:
> Acked-by: Dimitri Sivanich <sivanich@sgi.com>
>
> On Sun, Apr 21, 2013 at 08:01:07PM +0300, Dan Carpenter wrote:
> > The "info.fill" array isn't initialized so it can leak uninitialized
> > stack information to user space.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > v2: style changes
> >
> > diff --git a/drivers/misc/sgi-gru/grufile.c b/drivers/misc/sgi-gru/grufile.c
> > index 44d273c..0535d1e 100644
> > --- a/drivers/misc/sgi-gru/grufile.c
> > +++ b/drivers/misc/sgi-gru/grufile.c
> > @@ -172,6 +172,7 @@ static long gru_get_config_info(unsigned long arg)
> > nodesperblade = 2;
> > else
> > nodesperblade = 1;
> > + memset(&info, 0, sizeof(info));
> > info.cpus = num_online_cpus();
> > info.nodes = num_online_nodes();
> > info.blades = info.nodes / nodesperblade;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Robin Holt <holt@sgi.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
walter harms <wharms@bfs.de>
Subject: Re: [patch v2] gru: info leak in gru_get_config_info()
Date: Mon, 22 Apr 2013 11:41:18 -0500 [thread overview]
Message-ID: <20130422164118.GO3672@sgi.com> (raw)
In-Reply-To: <20130421173334.GA9023@sgi.com>
Acked-by: Robin Holt <holt@sgi.com>
On Sun, Apr 21, 2013 at 12:33:34PM -0500, Dimitri Sivanich wrote:
> Acked-by: Dimitri Sivanich <sivanich@sgi.com>
>
> On Sun, Apr 21, 2013 at 08:01:07PM +0300, Dan Carpenter wrote:
> > The "info.fill" array isn't initialized so it can leak uninitialized
> > stack information to user space.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > v2: style changes
> >
> > diff --git a/drivers/misc/sgi-gru/grufile.c b/drivers/misc/sgi-gru/grufile.c
> > index 44d273c..0535d1e 100644
> > --- a/drivers/misc/sgi-gru/grufile.c
> > +++ b/drivers/misc/sgi-gru/grufile.c
> > @@ -172,6 +172,7 @@ static long gru_get_config_info(unsigned long arg)
> > nodesperblade = 2;
> > else
> > nodesperblade = 1;
> > + memset(&info, 0, sizeof(info));
> > info.cpus = num_online_cpus();
> > info.nodes = num_online_nodes();
> > info.blades = info.nodes / nodesperblade;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-04-22 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 11:10 [patch] gru: info leak in gru_get_config_info() Dan Carpenter
2013-04-21 11:10 ` Dan Carpenter
2013-04-21 11:56 ` walter harms
2013-04-21 11:56 ` walter harms
2013-04-21 13:19 ` Robin Holt
2013-04-21 13:19 ` Robin Holt
2013-04-21 17:01 ` [patch v2] " Dan Carpenter
2013-04-21 17:01 ` Dan Carpenter
2013-04-21 17:33 ` Dimitri Sivanich
2013-04-21 17:33 ` Dimitri Sivanich
2013-04-22 16:41 ` Robin Holt [this message]
2013-04-22 16:41 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422164118.GO3672@sgi.com \
--to=holt@sgi.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.