From: Kent Overstreet <koverstreet@google.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: dwmw2@infradead.org, axboe@kernel.dk, shli@kernel.org,
Paul.Clements@steeleye.com, npiggin@kernel.dk, neilb@suse.de,
cjb@laptop.org, adrian.hunter@intel.com,
James.Bottomley@HansenPartnership.com, JBottomley@parallels.com,
linux-scsi@vger.kernel.org, linux-mtd@lists.infradead.org,
nbd-general@lists.sourceforge.net, linux-raid@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
jcmvbkbc@gmail.com, Namjae Jeon <namjae.jeon@samsung.com>
Subject: Re: [PATCH v2 0/9] fix max discard sectors limit
Date: Mon, 22 Apr 2013 14:23:24 -0700 [thread overview]
Message-ID: <20130422212324.GB4704@localhost> (raw)
In-Reply-To: <1366389602-19313-1-git-send-email-linkinjeon@gmail.com>
On Sat, Apr 20, 2013 at 01:40:02AM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with
> commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
> (block: add plug for blkdev_issue_discard )
>
> For example,
> 1) DISCARD rq-1 with size size 4GB
> 2) DISCARD rq-2 with size size 1GB
>
> If these 2 discard requests get merged, final request size will be 5GB.
>
> In this case, request's __data_len field may overflow as it can store
> max 4GB(unsigned int).
Complete NACK - like James said, this fix is nonsensical. This should be
fixed by just checking for overflow before merging requests, not with
weird hacks in the drivers.
WARNING: multiple messages have this Message-ID (diff)
From: Kent Overstreet <koverstreet@google.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: axboe@kernel.dk, nbd-general@lists.sourceforge.net,
linux-raid@vger.kernel.org, npiggin@kernel.dk,
linux-scsi@vger.kernel.org, neilb@suse.de, dwmw2@infradead.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Paul.Clements@steeleye.com, adrian.hunter@intel.com,
JBottomley@parallels.com, linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com, jcmvbkbc@gmail.com,
linux-mtd@lists.infradead.org, linux-mmc@vger.kernel.org,
cjb@laptop.org, shli@kernel.org
Subject: Re: [PATCH v2 0/9] fix max discard sectors limit
Date: Mon, 22 Apr 2013 14:23:24 -0700 [thread overview]
Message-ID: <20130422212324.GB4704@localhost> (raw)
In-Reply-To: <1366389602-19313-1-git-send-email-linkinjeon@gmail.com>
On Sat, Apr 20, 2013 at 01:40:02AM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with
> commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
> (block: add plug for blkdev_issue_discard )
>
> For example,
> 1) DISCARD rq-1 with size size 4GB
> 2) DISCARD rq-2 with size size 1GB
>
> If these 2 discard requests get merged, final request size will be 5GB.
>
> In this case, request's __data_len field may overflow as it can store
> max 4GB(unsigned int).
Complete NACK - like James said, this fix is nonsensical. This should be
fixed by just checking for overflow before merging requests, not with
weird hacks in the drivers.
next prev parent reply other threads:[~2013-04-22 21:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 16:40 [PATCH v2 0/9] fix max discard sectors limit Namjae Jeon
2013-04-19 16:40 ` Namjae Jeon
2013-04-20 19:50 ` James Bottomley
2013-04-20 19:50 ` James Bottomley
2013-04-21 1:37 ` Namjae Jeon
2013-04-21 1:37 ` Namjae Jeon
2013-04-21 1:37 ` Namjae Jeon
2013-04-26 7:33 ` Hannes Reinecke
2013-04-26 7:33 ` Hannes Reinecke
2013-04-26 7:33 ` Hannes Reinecke
2013-04-22 21:23 ` Kent Overstreet [this message]
2013-04-22 21:23 ` Kent Overstreet
2013-04-23 5:16 ` Namjae Jeon
2013-04-23 5:16 ` Namjae Jeon
2013-04-23 5:16 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422212324.GB4704@localhost \
--to=koverstreet@google.com \
--cc=JBottomley@parallels.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Paul.Clements@steeleye.com \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=cjb@laptop.org \
--cc=dwmw2@infradead.org \
--cc=jcmvbkbc@gmail.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=nbd-general@lists.sourceforge.net \
--cc=neilb@suse.de \
--cc=npiggin@kernel.dk \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.