* [PATCH] ASoC: generic-dmaengine-pcm: use a more common dma name
@ 2013-04-22 13:48 Shawn Guo
2013-04-22 13:50 ` Lars-Peter Clausen
2013-04-23 10:35 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Shawn Guo @ 2013-04-22 13:48 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown, Lars-Peter Clausen, Shawn Guo
The examples in Documentation/devicetree/bindings/dma/dma.txt recommends
the name for dma channel doing both RX and TX to be "rx-tx". This
becomes a common pattern that has been adopted by platforms that
converts to generic DMA bindings. Let's follow this common pattern in
generic-dmaengine-pcm.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
sound/soc/soc-generic-dmaengine-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c
index 5fd5ed4..98e1310 100644
--- a/sound/soc/soc-generic-dmaengine-pcm.c
+++ b/sound/soc/soc-generic-dmaengine-pcm.c
@@ -227,7 +227,7 @@ static void dmaengine_pcm_request_chan_of(struct dmaengine_pcm *pcm,
return;
if (pcm->flags & SND_DMAENGINE_PCM_FLAG_HALF_DUPLEX) {
- pcm->chan[0] = of_dma_request_slave_channel(of_node, "tx_rx");
+ pcm->chan[0] = of_dma_request_slave_channel(of_node, "rx-tx");
pcm->chan[1] = pcm->chan[0];
} else {
for (i = SNDRV_PCM_STREAM_PLAYBACK; i <= SNDRV_PCM_STREAM_CAPTURE; i++) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: generic-dmaengine-pcm: use a more common dma name
2013-04-22 13:48 [PATCH] ASoC: generic-dmaengine-pcm: use a more common dma name Shawn Guo
@ 2013-04-22 13:50 ` Lars-Peter Clausen
2013-04-23 10:35 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2013-04-22 13:50 UTC (permalink / raw)
To: Shawn Guo; +Cc: alsa-devel, Mark Brown
On 04/22/2013 03:48 PM, Shawn Guo wrote:
> The examples in Documentation/devicetree/bindings/dma/dma.txt recommends
> the name for dma channel doing both RX and TX to be "rx-tx". This
> becomes a common pattern that has been adopted by platforms that
> converts to generic DMA bindings. Let's follow this common pattern in
> generic-dmaengine-pcm.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> sound/soc/soc-generic-dmaengine-pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c
> index 5fd5ed4..98e1310 100644
> --- a/sound/soc/soc-generic-dmaengine-pcm.c
> +++ b/sound/soc/soc-generic-dmaengine-pcm.c
> @@ -227,7 +227,7 @@ static void dmaengine_pcm_request_chan_of(struct dmaengine_pcm *pcm,
> return;
>
> if (pcm->flags & SND_DMAENGINE_PCM_FLAG_HALF_DUPLEX) {
> - pcm->chan[0] = of_dma_request_slave_channel(of_node, "tx_rx");
> + pcm->chan[0] = of_dma_request_slave_channel(of_node, "rx-tx");
> pcm->chan[1] = pcm->chan[0];
> } else {
> for (i = SNDRV_PCM_STREAM_PLAYBACK; i <= SNDRV_PCM_STREAM_CAPTURE; i++) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: generic-dmaengine-pcm: use a more common dma name
2013-04-22 13:48 [PATCH] ASoC: generic-dmaengine-pcm: use a more common dma name Shawn Guo
2013-04-22 13:50 ` Lars-Peter Clausen
@ 2013-04-23 10:35 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-04-23 10:35 UTC (permalink / raw)
To: Shawn Guo; +Cc: alsa-devel, Lars-Peter Clausen
[-- Attachment #1.1: Type: text/plain, Size: 386 bytes --]
On Mon, Apr 22, 2013 at 09:48:45PM +0800, Shawn Guo wrote:
> The examples in Documentation/devicetree/bindings/dma/dma.txt recommends
> the name for dma channel doing both RX and TX to be "rx-tx". This
> becomes a common pattern that has been adopted by platforms that
> converts to generic DMA bindings. Let's follow this common pattern in
> generic-dmaengine-pcm.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-23 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-22 13:48 [PATCH] ASoC: generic-dmaengine-pcm: use a more common dma name Shawn Guo
2013-04-22 13:50 ` Lars-Peter Clausen
2013-04-23 10:35 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.