All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Girish K S <girishks2000@gmail.com>
Cc: spi-devel-general@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, grant.likely@secretlab.ca,
	t.figa@samsung.com
Subject: Re: [PATCH 1/3] spi: s3c64xx: added support for polling mode
Date: Tue, 23 Apr 2013 16:15:12 +0100	[thread overview]
Message-ID: <20130423151511.GR5019@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1366614565-3743-2-git-send-email-ks.giri@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

On Mon, Apr 22, 2013 at 12:39:23PM +0530, Girish K S wrote:
> From: Girish K S <girishks2000@gmail.com>
> 
> The 64xx spi driver supports partial polling mode.
> Only the last chunk of the transfer length is transferred
> or recieved in polling mode.

This appears to have a very noticable negative impact on SPI performance
on my S3C6410 based system.  Not delved into it to test why but are you
sure it's not mistakenly selecting polling?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] spi: s3c64xx: added support for polling mode
Date: Tue, 23 Apr 2013 16:15:12 +0100	[thread overview]
Message-ID: <20130423151511.GR5019@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1366614565-3743-2-git-send-email-ks.giri@samsung.com>

On Mon, Apr 22, 2013 at 12:39:23PM +0530, Girish K S wrote:
> From: Girish K S <girishks2000@gmail.com>
> 
> The 64xx spi driver supports partial polling mode.
> Only the last chunk of the transfer length is transferred
> or recieved in polling mode.

This appears to have a very noticable negative impact on SPI performance
on my S3C6410 based system.  Not delved into it to test why but are you
sure it's not mistakenly selecting polling?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130423/8081cceb/attachment.sig>

  reply	other threads:[~2013-04-23 15:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22  7:09 [PATCH 0/3] Polling support for s3c64xx spi controller Girish K S
2013-04-22  7:09 ` Girish K S
     [not found] ` <1366614565-3743-1-git-send-email-ks.giri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-04-22  7:09   ` [PATCH 1/3] spi: s3c64xx: added support for polling mode Girish K S
2013-04-22  7:09     ` Girish K S
2013-04-22  7:09     ` Girish K S
2013-04-23 15:15     ` Mark Brown [this message]
2013-04-23 15:15       ` Mark Brown
     [not found]       ` <20130423151511.GR5019-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-04-24  9:37         ` Girish KS
2013-04-24  9:37           ` Girish KS
2013-04-24  9:37           ` Girish KS
2013-04-22  7:09   ` [PATCH 2/3] spi: s3c64xx: Added provision for dedicated cs pin Girish K S
2013-04-22  7:09     ` Girish K S
2013-04-22  7:09     ` Girish K S
2013-04-23 14:42     ` Mark Brown
2013-04-23 14:42       ` Mark Brown
     [not found]       ` <20130423144256.GP5019-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-04-24  9:39         ` Girish KS
2013-04-24  9:39           ` Girish KS
2013-04-24  9:39           ` Girish KS
2013-04-22  7:09   ` [PATCH 3/3] spi: s3c64xx: Added support for exynos5440 spi Girish K S
2013-04-22  7:09     ` Girish K S
2013-04-22  7:09     ` Girish K S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130423151511.GR5019@opensource.wolfsonmicro.com \
    --to=broonie@kernel.org \
    --cc=girishks2000@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.