From: Richard Cochran <richardcochran@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: Willem de Bruijn <willemb@google.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Paul Chavent <Paul.Chavent@onera.fr>
Subject: Re: [PATCH net-next 0/5] PF_PACKET timestamping updates
Date: Tue, 23 Apr 2013 20:13:23 +0200 [thread overview]
Message-ID: <20130423181322.GC2675@netboy> (raw)
In-Reply-To: <5176842F.7040703@redhat.com>
On Tue, Apr 23, 2013 at 02:53:03PM +0200, Daniel Borkmann wrote:
>
> Well, for the {RX,TX}_RING there is really no other way except the really
> really ugly possibility to introduce yet another tpacket header with 3
> time-stamp fields (sw, sys, raw). I really do not like that. :-)
Yep. Your solution with the status bits is nicer than the normal
SO_TIMESTAMPING cmsg. I think there is currently no way for the kernel
to produce two or three time stamps at the same time, and so the whole
timestamp triple is rather pointless.
> At least here, if you have traffic from different devices, you either get
> what you want (e.g. hw ts), or you'll get a fallback sw ts. That is also
> the case in the current code without this patchset. At least this set would
> solve this issue of telling the user what ts source he sees.
Yes, very good.
Thanks,
Richard
next prev parent reply other threads:[~2013-04-23 18:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 10:39 [PATCH net-next 0/5] PF_PACKET timestamping updates Daniel Borkmann
2013-04-23 10:39 ` [PATCH net-next 1/5] packet: tx timestamping on tpacket ring Daniel Borkmann
2013-04-23 10:39 ` [PATCH net-next 2/5] packet: enable hardware " Daniel Borkmann
2013-04-23 12:13 ` Willem de Bruijn
2013-04-23 10:39 ` [PATCH net-next 3/5] packet: minor: convert status bits into shifting format Daniel Borkmann
2013-04-23 12:22 ` Willem de Bruijn
2013-04-23 10:39 ` [PATCH net-next 4/5] packet: if hw/sw ts enabled in rx/tx ring, report which ts we got Daniel Borkmann
2013-04-23 12:18 ` Willem de Bruijn
2013-04-23 10:39 ` [PATCH net-next 5/5] packet: doc: update timestamping part Daniel Borkmann
2013-04-23 12:20 ` Willem de Bruijn
2013-04-23 12:33 ` [PATCH net-next 0/5] PF_PACKET timestamping updates Willem de Bruijn
2013-04-23 12:53 ` Daniel Borkmann
2013-04-23 18:13 ` Richard Cochran [this message]
2013-04-23 18:07 ` Richard Cochran
2013-04-25 5:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423181322.GC2675@netboy \
--to=richardcochran@gmail.com \
--cc=Paul.Chavent@onera.fr \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.