All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Sethi Varun-B16395 <B16395-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Wood Scott-B07421
	<B07421-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org"
	<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org"
	<galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
	Yoder Stuart-B08248
	<B08248-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH 2/3 v14] iommu/fsl: Add additional iommu attributes required by the PAMU driver.
Date: Wed, 24 Apr 2013 12:51:18 +0200	[thread overview]
Message-ID: <20130424105117.GI17148@8bytes.org> (raw)
In-Reply-To: <C5ECD7A89D1DC44195F34B25E172658D4B4D9A-RL0Hj/+nBVCMXPU/2EZmt64g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>

On Tue, Apr 23, 2013 at 02:10:25PM +0000, Sethi Varun-B16395 wrote:
> I think it's fine to have the header under linux, actually I also the
> intel-iommu header under linux.

Yes, the difference is that VT-d runs on x86 and on ia64. So there is no
single arch where the header could be placed. The amd-iommu.h file on
the other hand is x86 only and should also be moved to asm/, as I just
found out :)

And as long as PAMU is only needed on a single architecture the header
should also be arch-specific. If that changes someday the header can be
moved to a generic place.


	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Sethi Varun-B16395 <B16395@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Yoder Stuart-B08248 <B08248@freescale.com>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/3 v14] iommu/fsl: Add additional iommu attributes required by the PAMU driver.
Date: Wed, 24 Apr 2013 12:51:18 +0200	[thread overview]
Message-ID: <20130424105117.GI17148@8bytes.org> (raw)
In-Reply-To: <C5ECD7A89D1DC44195F34B25E172658D4B4D9A@039-SN2MPN1-011.039d.mgd.msft.net>

On Tue, Apr 23, 2013 at 02:10:25PM +0000, Sethi Varun-B16395 wrote:
> I think it's fine to have the header under linux, actually I also the
> intel-iommu header under linux.

Yes, the difference is that VT-d runs on x86 and on ia64. So there is no
single arch where the header could be placed. The amd-iommu.h file on
the other hand is x86 only and should also be moved to asm/, as I just
found out :)

And as long as PAMU is only needed on a single architecture the header
should also be arch-specific. If that changes someday the header can be
moved to a generic place.


	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Sethi Varun-B16395 <B16395@freescale.com>
Cc: "iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"galak@kernel.crashing.org" <galak@kernel.crashing.org>,
	"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
	Yoder Stuart-B08248 <B08248@freescale.com>,
	Wood Scott-B07421 <B07421@freescale.com>
Subject: Re: [PATCH 2/3 v14] iommu/fsl: Add additional iommu attributes required by the PAMU driver.
Date: Wed, 24 Apr 2013 12:51:18 +0200	[thread overview]
Message-ID: <20130424105117.GI17148@8bytes.org> (raw)
In-Reply-To: <C5ECD7A89D1DC44195F34B25E172658D4B4D9A@039-SN2MPN1-011.039d.mgd.msft.net>

On Tue, Apr 23, 2013 at 02:10:25PM +0000, Sethi Varun-B16395 wrote:
> I think it's fine to have the header under linux, actually I also the
> intel-iommu header under linux.

Yes, the difference is that VT-d runs on x86 and on ia64. So there is no
single arch where the header could be placed. The amd-iommu.h file on
the other hand is x86 only and should also be moved to asm/, as I just
found out :)

And as long as PAMU is only needed on a single architecture the header
should also be arch-specific. If that changes someday the header can be
moved to a generic place.


	Joerg



  parent reply	other threads:[~2013-04-24 10:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23  4:35 [PATCH 1/3 v2] iommu: Move swap_pci_ref function to pci.h Varun Sethi
2013-04-23  4:35 ` Varun Sethi
     [not found] ` <1366691726-9023-1-git-send-email-Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-04-23  4:35   ` [PATCH 2/3 v14] iommu/fsl: Add additional iommu attributes required by the PAMU driver Varun Sethi
2013-04-23  4:35     ` Varun Sethi
2013-04-23 13:38     ` Joerg Roedel
2013-04-23 13:38       ` Joerg Roedel
     [not found]       ` <20130423133837.GG17148-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-23 14:10         ` Sethi Varun-B16395
2013-04-23 14:10           ` Sethi Varun-B16395
2013-04-23 14:10           ` Sethi Varun-B16395
     [not found]           ` <C5ECD7A89D1DC44195F34B25E172658D4B4D9A-RL0Hj/+nBVCMXPU/2EZmt64g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-04-24 10:51             ` Joerg Roedel [this message]
2013-04-24 10:51               ` Joerg Roedel
2013-04-24 10:51               ` Joerg Roedel
     [not found]               ` <20130424105117.GI17148-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-24 11:21                 ` Sethi Varun-B16395
2013-04-24 11:21                   ` Sethi Varun-B16395
2013-04-24 11:21                   ` Sethi Varun-B16395
2013-04-23 15:26         ` Yoder Stuart-B08248
2013-04-23 15:26           ` Yoder Stuart-B08248
2013-04-23 15:26           ` Yoder Stuart-B08248
2013-04-23  4:35   ` [PATCH 3/3 v14] iommu/fsl: Freescale PAMU driver and iommu implementation Varun Sethi
2013-04-23  4:35     ` Varun Sethi
2013-04-23 13:01   ` [PATCH 1/3 v2] iommu: Move swap_pci_ref function to pci.h Joerg Roedel
2013-04-23 13:01     ` Joerg Roedel
2013-04-23 13:01     ` Joerg Roedel
     [not found]     ` <20130423125827.GD2589-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-04-23 13:02       ` Sethi Varun-B16395
2013-04-23 13:02         ` Sethi Varun-B16395
2013-04-23 13:02         ` Sethi Varun-B16395

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130424105117.GI17148@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=B07421-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=B08248-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=B16395-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
    --cc=galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.