* [PATCH 2/2] ASoC: mxs-sgtl5000: Remove unneeded fields from snd_soc_dai_link
2013-04-24 16:23 [PATCH 1/2] ASoC: mxs-sgtl5000: Remove unneeded 'ret' variable Fabio Estevam
@ 2013-04-24 16:23 ` Fabio Estevam
2013-04-25 5:24 ` Shawn Guo
2013-04-25 5:22 ` [PATCH 1/2] ASoC: mxs-sgtl5000: Remove unneeded 'ret' variable Shawn Guo
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2013-04-24 16:23 UTC (permalink / raw)
To: broonie; +Cc: Fabio Estevam, alsa-devel, shawn.guo, kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
It makes no sense to hardcode the I2C bus into the codec_name field.
cpu_dai_name and platform_name are also overwritten later in
mxs_sgtl5000_probe_dt().
So remove the three fields, as mxs platform is dt-only platform.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/mxs/mxs-sgtl5000.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/soc/mxs/mxs-sgtl5000.c b/sound/soc/mxs/mxs-sgtl5000.c
index 4f74b05..1b134d7 100644
--- a/sound/soc/mxs/mxs-sgtl5000.c
+++ b/sound/soc/mxs/mxs-sgtl5000.c
@@ -90,17 +90,11 @@ static struct snd_soc_dai_link mxs_sgtl5000_dai[] = {
.name = "HiFi Tx",
.stream_name = "HiFi Playback",
.codec_dai_name = "sgtl5000",
- .codec_name = "sgtl5000.0-000a",
- .cpu_dai_name = "mxs-saif.0",
- .platform_name = "mxs-saif.0",
.ops = &mxs_sgtl5000_hifi_ops,
}, {
.name = "HiFi Rx",
.stream_name = "HiFi Capture",
.codec_dai_name = "sgtl5000",
- .codec_name = "sgtl5000.0-000a",
- .cpu_dai_name = "mxs-saif.1",
- .platform_name = "mxs-saif.1",
.ops = &mxs_sgtl5000_hifi_ops,
},
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] ASoC: mxs-sgtl5000: Remove unneeded 'ret' variable
2013-04-24 16:23 [PATCH 1/2] ASoC: mxs-sgtl5000: Remove unneeded 'ret' variable Fabio Estevam
2013-04-24 16:23 ` [PATCH 2/2] ASoC: mxs-sgtl5000: Remove unneeded fields from snd_soc_dai_link Fabio Estevam
@ 2013-04-25 5:22 ` Shawn Guo
2013-04-25 10:59 ` Mark Brown
2013-05-06 11:43 ` Mark Brown
3 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2013-04-25 5:22 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, alsa-devel, broonie, kernel
On Wed, Apr 24, 2013 at 01:23:14PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Variable 'ret' is not needed here, so just remove it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ASoC: mxs-sgtl5000: Remove unneeded 'ret' variable
2013-04-24 16:23 [PATCH 1/2] ASoC: mxs-sgtl5000: Remove unneeded 'ret' variable Fabio Estevam
2013-04-24 16:23 ` [PATCH 2/2] ASoC: mxs-sgtl5000: Remove unneeded fields from snd_soc_dai_link Fabio Estevam
2013-04-25 5:22 ` [PATCH 1/2] ASoC: mxs-sgtl5000: Remove unneeded 'ret' variable Shawn Guo
@ 2013-04-25 10:59 ` Mark Brown
2013-05-06 11:43 ` Mark Brown
3 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2013-04-25 10:59 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, alsa-devel, shawn.guo, kernel
[-- Attachment #1.1: Type: text/plain, Size: 203 bytes --]
On Wed, Apr 24, 2013 at 01:23:14PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Variable 'ret' is not needed here, so just remove it.
Applied both, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ASoC: mxs-sgtl5000: Remove unneeded 'ret' variable
2013-04-24 16:23 [PATCH 1/2] ASoC: mxs-sgtl5000: Remove unneeded 'ret' variable Fabio Estevam
` (2 preceding siblings ...)
2013-04-25 10:59 ` Mark Brown
@ 2013-05-06 11:43 ` Mark Brown
3 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2013-05-06 11:43 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, alsa-devel, shawn.guo, kernel
[-- Attachment #1.1: Type: text/plain, Size: 203 bytes --]
On Wed, Apr 24, 2013 at 01:23:14PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Variable 'ret' is not needed here, so just remove it.
Applied both, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread