From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 1/7] arch: toolchain: Introduce binary formats BINFMT_*.
Date: Thu, 25 Apr 2013 16:22:09 +0200 [thread overview]
Message-ID: <20130425162209.49fb4ec9@skate> (raw)
In-Reply-To: <1366279592-9055-1-git-send-email-sonic.adi@gmail.com>
Dear Sonic Zhang,
On Thu, 18 Apr 2013 18:06:26 +0800, Sonic Zhang wrote:
> diff --git a/Config.in.legacy b/Config.in.legacy
> index d90132c..6867ff3 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -104,4 +104,18 @@ config BR2_PACKAGE_INPUT_TOOLS_EVTEST
> help
> The evtest program from input-tools is now a separate package.
>
> +choice
> + prompt "Target ABI"
> + depends on BR2_bfin
> + default BR2_BFIN_FDPIC
> +
> +config BR2_BFIN_FDPIC
> + bool "FDPIC"
> +
> +config BR2_BFIN_FLAT
> + bool "FLAT"
> + select BR2_PREFER_STATIC_LIB
> +
> +endchoice
Hum, that's not how the legacy stuff works. You don't have to duplicate
the choice, but instead do something like:
config BR2_BFIN_FDPIC
bool "BR2_BFIN_FDPIC is now BR2_BINFMT_FDPIC"
select BR2_BINFMT_FDPIC
select BR2_LEGACY
config BR2_BFIN_FLAT
bool "BR2_BFIN_FLAT is now BR2_BINFMT_FLAT"
select BR2_BINFMT_FLAT
select BR2_LEGACY
Once this is fixed, you'll have my Acked-by on this patch, the rest
looks ok to me.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2013-04-25 14:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 10:06 [Buildroot] [PATCH v6 1/7] arch: toolchain: Introduce binary formats BINFMT_* Sonic Zhang
2013-04-18 10:06 ` [Buildroot] [PATCH v6 2/7] arch: Add blackfin CPU choice Sonic Zhang
2013-04-23 5:53 ` Sonic Zhang
2013-04-25 14:24 ` Thomas Petazzoni
2013-04-18 10:06 ` [Buildroot] [PATCH v6 3/7] arch: toolchain: Introduce target CPU revision Sonic Zhang
2013-04-23 5:53 ` Sonic Zhang
2013-04-25 14:25 ` Thomas Petazzoni
2013-04-18 10:06 ` [Buildroot] [PATCH v6 4/7] arch: toolchain: Introduce binary format FLAT types Sonic Zhang
2013-04-25 14:27 ` Thomas Petazzoni
2013-04-18 10:06 ` [Buildroot] [PATCH v6 5/7] package: Introduce package-specific BINFMT_FLAT options Sonic Zhang
2013-04-23 9:17 ` Sonic Zhang
2013-04-25 14:30 ` Thomas Petazzoni
2013-04-18 10:06 ` [Buildroot] [PATCH v6 6/7] arch: toolchain: Install blackfin FDPIC and FLAT libraries in external toolchain makefile Sonic Zhang
2013-04-26 3:21 ` Sonic Zhang
2013-05-02 7:36 ` Sonic Zhang
2013-05-02 10:01 ` Thomas Petazzoni
2013-05-02 10:11 ` Sonic Zhang
2013-05-03 18:46 ` Thomas Petazzoni
2013-05-06 6:36 ` Sonic Zhang
2013-04-18 10:06 ` [Buildroot] [PATCH v6 7/7] package: Introduce NOMMU symbol Sonic Zhang
2013-04-26 3:22 ` Sonic Zhang
2013-04-23 5:52 ` [Buildroot] [PATCH v6 1/7] arch: toolchain: Introduce binary formats BINFMT_* Sonic Zhang
2013-04-25 14:22 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425162209.49fb4ec9@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.