All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 6/7] arch: toolchain: Install blackfin FDPIC and FLAT libraries in external toolchain makefile.
Date: Fri, 3 May 2013 20:46:56 +0200	[thread overview]
Message-ID: <20130503204656.23563490@skate> (raw)
In-Reply-To: <CAJxxZ0NC2O2D5m4COx-r=-cT_TJoyGkXRxqNYXt-=7ze5+xcmg@mail.gmail.com>

Dear Sonic Zhang,

On Thu, 2 May 2013 18:11:40 +0800, Sonic Zhang wrote:

> > Wasn't my suggestion:
> >
> > config BR2_BFIN_INSTALL_FLAT_SHARED
> >         bool "Install FLAT shared libraries" if !BR2_BINFMT_FLAT_SHARED
> >         depends on BR2_bfin
> >         default y if BR2_BINFMT_FLAT_SHARED
> >
> > So: option enabled by default when BR2_BINFMT_FLAT_SHARED, and the
> > prompt is shown to optionally enable/disable it when
> > BR2_BINFMT_FLAT_SHARED is not selected.
> 
> In this way, the developer can disable the option
> BR2_BFIN_INSTALL_FLAT_SHARED in share flat binary mode. This is
> incorrect. My solution ensures the developer have no way to disable
> BR2_BFIN_INSTALL_FLAT_SHARED when BR2_BINFMT_FLAT_SHARED is selected.

This is what my proposed code is doing. I've just tested it on a small
example:

config BR2_OPTIONA
	bool "optionA"

config BR2_OPTIONB
	bool "optionB" if !BR2_OPTIONA
	default y if BR2_OPTIONA

With the following results:

 * If the user selects option A, then the possibility of choosing the
   value for option B disappears, and option B is forcefully enabled.

 * If the user doesn't select option A, then he is free to select or
   not select option B.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-05-03 18:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-18 10:06 [Buildroot] [PATCH v6 1/7] arch: toolchain: Introduce binary formats BINFMT_* Sonic Zhang
2013-04-18 10:06 ` [Buildroot] [PATCH v6 2/7] arch: Add blackfin CPU choice Sonic Zhang
2013-04-23  5:53   ` Sonic Zhang
2013-04-25 14:24   ` Thomas Petazzoni
2013-04-18 10:06 ` [Buildroot] [PATCH v6 3/7] arch: toolchain: Introduce target CPU revision Sonic Zhang
2013-04-23  5:53   ` Sonic Zhang
2013-04-25 14:25   ` Thomas Petazzoni
2013-04-18 10:06 ` [Buildroot] [PATCH v6 4/7] arch: toolchain: Introduce binary format FLAT types Sonic Zhang
2013-04-25 14:27   ` Thomas Petazzoni
2013-04-18 10:06 ` [Buildroot] [PATCH v6 5/7] package: Introduce package-specific BINFMT_FLAT options Sonic Zhang
2013-04-23  9:17   ` Sonic Zhang
2013-04-25 14:30   ` Thomas Petazzoni
2013-04-18 10:06 ` [Buildroot] [PATCH v6 6/7] arch: toolchain: Install blackfin FDPIC and FLAT libraries in external toolchain makefile Sonic Zhang
2013-04-26  3:21   ` Sonic Zhang
2013-05-02  7:36   ` Sonic Zhang
2013-05-02 10:01     ` Thomas Petazzoni
2013-05-02 10:11       ` Sonic Zhang
2013-05-03 18:46         ` Thomas Petazzoni [this message]
2013-05-06  6:36           ` Sonic Zhang
2013-04-18 10:06 ` [Buildroot] [PATCH v6 7/7] package: Introduce NOMMU symbol Sonic Zhang
2013-04-26  3:22   ` Sonic Zhang
2013-04-23  5:52 ` [Buildroot] [PATCH v6 1/7] arch: toolchain: Introduce binary formats BINFMT_* Sonic Zhang
2013-04-25 14:22 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130503204656.23563490@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.