From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Josef Ahmad <josef.ahmad-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>,
Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Dirk Brandewie
<dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] i2c-designware: fix RX FIFO overrun
Date: Thu, 25 Apr 2013 19:43:48 +0200 [thread overview]
Message-ID: <20130425174348.GA3612@the-dreams.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1304241110480.32505@localhost>
On Wed, Apr 24, 2013 at 11:11:38AM +0100, Josef Ahmad wrote:
> From 8a4773d0c0df6fe2e816ad37fde30a2d90a1ad31 Mon Sep 17 00:00:00 2001
> From: Josef Ahmad <josef.ahmad-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Date: Fri, 19 Apr 2013 17:28:10 +0100
> Subject: [PATCH] i2c-designware: fix RX FIFO overrun
>
> i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive
> to/from the bus into the TX FIFO.
> For master-rx transactions, the maximum amount of data that can be
> received is calculated depending solely on TX and RX FIFO load.
>
> This is racy - TX FIFO may contain master-rx data yet to be
> processed, which will eventually land into the RX FIFO. This
> data is not taken into account and the function may request more
> data than the controller is actually capable of storing.
>
> This patch ensures the driver takes into account the outstanding
> master-rx data in TX FIFO to prevent RX FIFO overrun.
>
> Signed-off-by: Josef Ahmad <josef.ahmad-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> Acked-by: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Still can't apply :( Whitespace problems in the patch context :(
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Josef Ahmad <josef.ahmad@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Ben Dooks <ben-linux@fluff.org>,
Jean Delvare <khali@linux-fr.org>, Stefan Roese <sr@denx.de>,
Axel Lin <axel.lin@gmail.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Dirk Brandewie <dirk.brandewie@gmail.com>
Subject: Re: [PATCH] i2c-designware: fix RX FIFO overrun
Date: Thu, 25 Apr 2013 19:43:48 +0200 [thread overview]
Message-ID: <20130425174348.GA3612@the-dreams.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1304241110480.32505@localhost>
On Wed, Apr 24, 2013 at 11:11:38AM +0100, Josef Ahmad wrote:
> From 8a4773d0c0df6fe2e816ad37fde30a2d90a1ad31 Mon Sep 17 00:00:00 2001
> From: Josef Ahmad <josef.ahmad@linux.intel.com>
> Date: Fri, 19 Apr 2013 17:28:10 +0100
> Subject: [PATCH] i2c-designware: fix RX FIFO overrun
>
> i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive
> to/from the bus into the TX FIFO.
> For master-rx transactions, the maximum amount of data that can be
> received is calculated depending solely on TX and RX FIFO load.
>
> This is racy - TX FIFO may contain master-rx data yet to be
> processed, which will eventually land into the RX FIFO. This
> data is not taken into account and the function may request more
> data than the controller is actually capable of storing.
>
> This patch ensures the driver takes into account the outstanding
> master-rx data in TX FIFO to prevent RX FIFO overrun.
>
> Signed-off-by: Josef Ahmad <josef.ahmad@linux.intel.com>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Still can't apply :( Whitespace problems in the patch context :(
next prev parent reply other threads:[~2013-04-25 17:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 18:05 [PATCH] i2c-designware: fix RX FIFO overrun Josef Ahmad
2013-04-19 20:43 ` Bryan O'Donoghue
[not found] ` <5171AC7D.70503-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org>
2013-04-19 21:20 ` Josef Ahmad
2013-04-19 21:20 ` Josef Ahmad
2013-04-22 7:19 ` Mika Westerberg
2013-04-22 7:19 ` Mika Westerberg
[not found] ` <20130422071943.GK1283-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-04-22 11:30 ` Josef Ahmad
2013-04-22 11:30 ` Josef Ahmad
[not found] ` <53398.163.33.213.79.1366630241.squirrel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-04-22 12:28 ` Mika Westerberg
2013-04-22 12:28 ` Mika Westerberg
[not found] ` <20130422122808.GO1283-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-04-22 14:08 ` Josef Ahmad
2013-04-22 14:08 ` Josef Ahmad
2013-04-23 16:35 ` Wolfram Sang
2013-04-23 16:35 ` Wolfram Sang
[not found] ` <20130423163543.GB3228-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-04-23 17:44 ` Josef Ahmad
2013-04-23 17:44 ` Josef Ahmad
[not found] ` <51465.163.33.213.85.1366739082.squirrel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-04-23 18:27 ` Wolfram Sang
2013-04-23 18:27 ` Wolfram Sang
[not found] ` <20130423182707.GA3649-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-04-24 10:11 ` Josef Ahmad
2013-04-24 10:11 ` Josef Ahmad
2013-04-25 17:43 ` Wolfram Sang [this message]
2013-04-25 17:43 ` Wolfram Sang
[not found] ` <20130425174348.GA3612-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-05-08 13:31 ` Josef Ahmad
2013-05-08 13:31 ` Josef Ahmad
2013-05-08 13:34 ` Josef Ahmad
2013-05-17 8:23 ` Wolfram Sang
2013-05-17 8:23 ` Wolfram Sang
2013-05-17 8:32 ` Wolfram Sang
2013-05-17 8:32 ` Wolfram Sang
2013-05-17 10:59 ` Josef Ahmad
2013-05-17 10:59 ` Josef Ahmad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425174348.GA3612@the-dreams.de \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=josef.ahmad-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=sr-ynQEQJNshbs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.