From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH] mm, highmem: remove useless virtual variable in page_address_map
Date: Fri, 26 Apr 2013 09:21:07 +0900 [thread overview]
Message-ID: <20130426002107.GA3075@lge.com> (raw)
In-Reply-To: <20130425150057.c25220a8f03e068f5bea5d58@linux-foundation.org>
On Thu, Apr 25, 2013 at 03:00:57PM -0700, Andrew Morton wrote:
> On Mon, 22 Apr 2013 17:26:28 +0900 Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
>
> > We can get virtual address without virtual field.
> > So remove it.
> >
> > ...
> >
> > --- a/mm/highmem.c
> > +++ b/mm/highmem.c
> > @@ -320,7 +320,6 @@ EXPORT_SYMBOL(kunmap_high);
> > */
> > struct page_address_map {
> > struct page *page;
> > - void *virtual;
> > struct list_head list;
> > };
> >
> > @@ -362,7 +361,10 @@ void *page_address(const struct page *page)
> >
> > list_for_each_entry(pam, &pas->lh, list) {
> > if (pam->page == page) {
> > - ret = pam->virtual;
> > + int nr;
> > +
> > + nr = pam - page_address_map;
>
> Doesn't compile. Presumably you meant page_address_maps.
>
> I'll drop this - please resend if/when it has been runtime tested.
Sorry for that.
I'll resend when it has been runtime tested.
Thanks.
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH] mm, highmem: remove useless virtual variable in page_address_map
Date: Fri, 26 Apr 2013 09:21:07 +0900 [thread overview]
Message-ID: <20130426002107.GA3075@lge.com> (raw)
In-Reply-To: <20130425150057.c25220a8f03e068f5bea5d58@linux-foundation.org>
On Thu, Apr 25, 2013 at 03:00:57PM -0700, Andrew Morton wrote:
> On Mon, 22 Apr 2013 17:26:28 +0900 Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
>
> > We can get virtual address without virtual field.
> > So remove it.
> >
> > ...
> >
> > --- a/mm/highmem.c
> > +++ b/mm/highmem.c
> > @@ -320,7 +320,6 @@ EXPORT_SYMBOL(kunmap_high);
> > */
> > struct page_address_map {
> > struct page *page;
> > - void *virtual;
> > struct list_head list;
> > };
> >
> > @@ -362,7 +361,10 @@ void *page_address(const struct page *page)
> >
> > list_for_each_entry(pam, &pas->lh, list) {
> > if (pam->page == page) {
> > - ret = pam->virtual;
> > + int nr;
> > +
> > + nr = pam - page_address_map;
>
> Doesn't compile. Presumably you meant page_address_maps.
>
> I'll drop this - please resend if/when it has been runtime tested.
Sorry for that.
I'll resend when it has been runtime tested.
Thanks.
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-26 0:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 8:26 [PATCH] mm, highmem: remove useless virtual variable in page_address_map Joonsoo Kim
2013-04-22 8:26 ` Joonsoo Kim
2013-04-25 22:00 ` Andrew Morton
2013-04-25 22:00 ` Andrew Morton
2013-04-26 0:21 ` Joonsoo Kim [this message]
2013-04-26 0:21 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130426002107.GA3075@lge.com \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.