From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] dmaengine: ste_dma40: Allow memcpy channels to be configured from DT
Date: Tue, 30 Apr 2013 22:42:23 +0200 [thread overview]
Message-ID: <201304302242.24002.arnd@arndb.de> (raw)
In-Reply-To: <1367336497-10650-1-git-send-email-lee.jones@linaro.org>
On Tuesday 30 April 2013, Lee Jones wrote:
> @@ -6,6 +6,8 @@ Required properties:
> - reg-names: Names of the above areas to use during resource look-up
> - interrupt: Should contain the DMAC interrupt number
> - #dma-cells: must be <3>
> +- memcpy-channels: Channels to be used for memcpy
> +- memcpy-num-chans: Number of channels to be used for memcpy
>
> Optional properties:
> - dma-channels: Number of channels supported by hardware - if not present
> @@ -21,6 +23,8 @@ Example:
> interrupts = <0 25 0x4>;
>
> #dma-cells = <2>;
> + memcpy-channels = <56, 57, 58, 59, 60>;
> + memcpy-num-chans = <5>;
> dma-channels = <8>;
> };
>
I think you should remove the memcpy-num-chans property and instead evaluate the
length of the memcpy-channels property. Aside from this, it looks fine.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@stericsson.com,
srinidhi.kasagar@stericsson.com,
Vinod Koul <vinod.koul@intel.com>, Dan Williams <djbw@fb.com>,
Per Forlin <per.forlin@stericsson.com>,
Rabin Vincent <rabin@rab.in>
Subject: Re: [PATCH 1/5] dmaengine: ste_dma40: Allow memcpy channels to be configured from DT
Date: Tue, 30 Apr 2013 22:42:23 +0200 [thread overview]
Message-ID: <201304302242.24002.arnd@arndb.de> (raw)
In-Reply-To: <1367336497-10650-1-git-send-email-lee.jones@linaro.org>
On Tuesday 30 April 2013, Lee Jones wrote:
> @@ -6,6 +6,8 @@ Required properties:
> - reg-names: Names of the above areas to use during resource look-up
> - interrupt: Should contain the DMAC interrupt number
> - #dma-cells: must be <3>
> +- memcpy-channels: Channels to be used for memcpy
> +- memcpy-num-chans: Number of channels to be used for memcpy
>
> Optional properties:
> - dma-channels: Number of channels supported by hardware - if not present
> @@ -21,6 +23,8 @@ Example:
> interrupts = <0 25 0x4>;
>
> #dma-cells = <2>;
> + memcpy-channels = <56, 57, 58, 59, 60>;
> + memcpy-num-chans = <5>;
> dma-channels = <8>;
> };
>
I think you should remove the memcpy-num-chans property and instead evaluate the
length of the memcpy-channels property. Aside from this, it looks fine.
Arnd
next prev parent reply other threads:[~2013-04-30 20:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 15:41 [PATCH 1/5] dmaengine: ste_dma40: Allow memcpy channels to be configured from DT Lee Jones
2013-04-30 15:41 ` Lee Jones
2013-04-30 15:41 ` [PATCH 2/5] ARM: ux500: Pass DMA memcpy channels though Device Tree Lee Jones
2013-04-30 15:41 ` Lee Jones
2013-04-30 15:41 ` [PATCH 3/5] ARM: ux500: Stop passing DMA platform data though AUXDATA Lee Jones
2013-04-30 15:41 ` Lee Jones
2013-04-30 20:43 ` Arnd Bergmann
2013-04-30 20:43 ` Arnd Bergmann
2013-05-02 11:29 ` Srinidhi Kasagar
2013-05-02 11:29 ` Srinidhi Kasagar
2013-04-30 15:41 ` [PATCH 4/5] dmaengine: ste_dma40: Fetch the number of physical channels from DT Lee Jones
2013-04-30 15:41 ` Lee Jones
2013-04-30 15:41 ` [PATCH 5/5] dmaengine: ste_dma40: Fetch disabled " Lee Jones
2013-04-30 15:41 ` Lee Jones
2013-05-01 9:54 ` [PATCH 5/5 v2] " Lee Jones
2013-05-01 9:54 ` Lee Jones
2013-05-01 10:27 ` Arnd Bergmann
2013-05-01 10:27 ` Arnd Bergmann
2013-04-30 20:42 ` Arnd Bergmann [this message]
2013-04-30 20:42 ` [PATCH 1/5] dmaengine: ste_dma40: Allow memcpy channels to be configured " Arnd Bergmann
2013-05-01 9:51 ` Lee Jones
2013-05-01 9:51 ` Lee Jones
2013-05-01 9:52 ` [PATCH 1/5 v2] " Lee Jones
2013-05-01 9:52 ` Lee Jones
2013-05-01 10:27 ` Arnd Bergmann
2013-05-01 10:27 ` Arnd Bergmann
2013-05-03 11:16 ` Linus Walleij
2013-05-03 11:16 ` Linus Walleij
2013-05-03 11:57 ` Lee Jones
2013-05-03 11:57 ` Lee Jones
2013-05-03 12:02 ` Linus Walleij
2013-05-03 12:02 ` Linus Walleij
2013-05-03 12:11 ` Lee Jones
2013-05-03 12:11 ` Lee Jones
2013-05-03 13:42 ` Linus Walleij
2013-05-03 13:42 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304302242.24002.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.