From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: agraf@suse.de, aliguori@us.ibm.com,
"Jason Wang" <jasowang@redhat.com>,
"Jesse Larrew" <jlarrew@linux.vnet.ibm.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
qemu-devel@nongnu.org,
"KONRAD Frédéric" <fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len
Date: Thu, 2 May 2013 10:59:02 +0200 [thread overview]
Message-ID: <20130502105902.09a823fe@gondolin> (raw)
In-Reply-To: <20130429200952.GA19286@redhat.com>
On Mon, 29 Apr 2013 23:09:52 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Mon, Apr 29, 2013 at 08:45:50PM +0200, KONRAD Frédéric wrote:
> > Maybe we can move the two firsts line in the virtio_net_pci_init before the
> > init if they are usefull in the
> > config_size computing:
> >
> >
> > proxy->host_features |= 0x1 << VIRTIO_F_NOTIFY_ON_EMPTY;
> > proxy->host_features |= 0x1 << VIRTIO_F_BAD_FEATURE;
>
> Bus can set VIRTIO_F_NOTIFY_ON_EMPTY and VIRTIO_F_BAD_FEATURE
> later, this is not going to affect anything.
>
> Reason is, VIRTIO_F_NOTIFY_ON_EMPTY and VIRTIO_F_BAD_FEATURE
> are compatibility hacks which is why we dont
> have them for s390. It's probably a bug that
> we have them for virtio-ccw.
>
Yes, probably (I used virtio-pci as my inspiration a lot...)
I'll check whether killing this works as expected.
prev parent reply other threads:[~2013-05-02 8:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 6:21 [Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len Jason Wang
2013-04-25 6:59 ` Michael S. Tsirkin
2013-04-25 7:02 ` Jason Wang
2013-04-25 7:06 ` Michael S. Tsirkin
2013-04-25 7:52 ` Jason Wang
2013-04-29 14:42 ` Jesse Larrew
2013-04-29 14:55 ` KONRAD Frédéric
2013-04-29 15:14 ` Jesse Larrew
2013-04-29 15:29 ` KONRAD Frédéric
2013-04-29 15:55 ` Jesse Larrew
2013-04-29 16:02 ` Michael S. Tsirkin
2013-04-29 16:14 ` KONRAD Frédéric
2013-04-29 16:21 ` Michael S. Tsirkin
2013-04-29 16:30 ` Michael S. Tsirkin
2013-04-29 16:41 ` KONRAD Frédéric
2013-04-29 17:01 ` Michael S. Tsirkin
2013-04-29 17:23 ` KONRAD Frédéric
2013-04-29 17:52 ` Michael S. Tsirkin
2013-04-29 18:01 ` KONRAD Frédéric
2013-04-29 18:15 ` Michael S. Tsirkin
2013-04-29 18:45 ` KONRAD Frédéric
2013-04-29 20:09 ` Michael S. Tsirkin
2013-04-30 8:47 ` KONRAD Frédéric
2013-04-30 9:02 ` Michael S. Tsirkin
2013-05-02 9:02 ` Cornelia Huck
2013-05-02 8:59 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502105902.09a823fe@gondolin \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=fred.konrad@greensocs.com \
--cc=jasowang@redhat.com \
--cc=jlarrew@linux.vnet.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.