[Cluster-devel] [PATCH] dlm_tool: Trimming garbages at in Expecting reply output

[Cluster-devel] [PATCH] dlm_tool: Trimming garbages at in Expecting reply output

[Masatake YAMATO]

The buffer used in "Expecting reply" of dlm_tool lockdebug output is
used as C string (via printf %s) but not terminated with nul char.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
---
 dlm/tool/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlm/tool/main.c b/dlm/tool/main.c
index 4752008..a404be3 100644
--- a/dlm/tool/main.c
+++ b/dlm/tool/main.c
@@ -822,7 +822,7 @@ static void do_waiters(char *name, struct summary *sum)
 		/* parse the resource name from the remainder of the line */
 		j = 0;
 		spaces = 0;
-
+		memset(rname, 0, sizeof(rname));
 		for (i = 0; i < LOCK_LINE_MAX; i++) {
 			if (line[i] == '\n')
 				break;
-- 
1.7.11.7

[Cluster-devel] [PATCH] dlm_tool: Trimming garbages at in Expecting reply output

[David Teigland]

On Thu, May 02, 2013 at 09:19:21PM +0900, Masatake YAMATO wrote:
> The buffer used in "Expecting reply" of dlm_tool lockdebug output is
> used as C string (via printf %s) but not terminated with nul char.

Yes, thanks.  This was fixed for some time in dlm.git.  I'm afraid we'll
need to go through the bz process to fix in RHEL.
Dave

[Cluster-devel] [PATCH] dlm_tool: Trimming garbages at in Expecting reply output

[Masatake YAMATO]

> On Thu, May 02, 2013 at 09:19:21PM +0900, Masatake YAMATO wrote:
>> The buffer used in "Expecting reply" of dlm_tool lockdebug output is
>> used as C string (via printf %s) but not terminated with nul char.
> 
> Yes, thanks.  This was fixed for some time in dlm.git.  I'm afraid we'll
> need to go through the bz process to fix in RHEL.
> Dave

Ugh. I should look at https://git.fedorahosted.org/git/dlm.git.
I refereed RHEL60 branch of https://git.fedorahosted.org/cgit/cluster.git/.

Masatake YAMATO