From: Olaf Hering <olaf@aepfle.de>
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org
Subject: Re: guest crash in wrmsr_hypervisor_regs if hypercall page is paged out
Date: Thu, 2 May 2013 19:46:46 +0200 [thread overview]
Message-ID: <20130502174646.GA28842@aepfle.de> (raw)
In-Reply-To: <5182A26B02000078000D2C92@nat28.tlf.novell.com>
On Thu, May 02, Jan Beulich wrote:
> >>> On 02.05.13 at 17:20, Olaf Hering <olaf@aepfle.de> wrote:
> > On Thu, May 02, Jan Beulich wrote:
> >
> >> We can't put a vCPU to sleep at arbitrary points yet, which means
> >> that right now the caller of the function is responsible for the
> >> wait-and-retry - normally that would be in hypercall handlers, but
> >> obviously you need this here too.
> >
> > Yes, thats the issue.
> >
> > vmx_msr_write_intercept and svm_msr_write_intercept could just return
> > X86EMUL_RETRY to their callers.
> >
> > How should emulate_privileged_op handle the wrmsr_hypervisor_regs
> > failure due to a paged page?
>
> That's a PV only path, hence no need to consider paging. Just
> assert that the return value of X86EMUL_OKAY.
I sent a patch which fixes this issue for me. The 4.2 branch has
appearently the same issue.
Olaf
prev parent reply other threads:[~2013-05-02 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 18:19 guest crash in wrmsr_hypervisor_regs if hypercall page is paged out Olaf Hering
2013-05-02 11:20 ` Tim Deegan
2013-05-02 14:43 ` Olaf Hering
2013-05-02 14:52 ` Tim Deegan
2013-05-02 14:58 ` Jan Beulich
2013-05-02 15:20 ` Olaf Hering
2013-05-02 15:29 ` Jan Beulich
2013-05-02 17:46 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502174646.GA28842@aepfle.de \
--to=olaf@aepfle.de \
--cc=JBeulich@suse.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.