From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kirkwood: add button for OpenBlock A6
Date: Thu, 2 May 2013 16:53:16 -0300 [thread overview]
Message-ID: <20130502195315.GA4107@localhost> (raw)
In-Reply-To: <1367523802-16372-1-git-send-email-gregory.clement@free-electrons.com>
Hi Gregory,
On Thu, May 02, 2013 at 09:43:22PM +0200, Gregory CLEMENT wrote:
> The OpenBlocks A6 board has one software-controlled button on the
> front side, labeled "INIT", so we add minimal support for this button
> in the kernel.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> index d27f724..627d8d0 100644
> --- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> @@ -209,4 +209,17 @@
> gpios = <&gpio1 11 1>;
> };
> };
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + button at 1 {
> + label = "Init Button";
> + linux,code = <116>;
> + gpios = <&gpio1 6 0>;
> + };
> + };
> +
> };
Shouldn't you add a proper pinctrl entry for this as well?
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: kirkwood: add button for OpenBlock A6
Date: Thu, 2 May 2013 16:53:16 -0300 [thread overview]
Message-ID: <20130502195315.GA4107@localhost> (raw)
In-Reply-To: <1367523802-16372-1-git-send-email-gregory.clement@free-electrons.com>
Hi Gregory,
On Thu, May 02, 2013 at 09:43:22PM +0200, Gregory CLEMENT wrote:
> The OpenBlocks A6 board has one software-controlled button on the
> front side, labeled "INIT", so we add minimal support for this button
> in the kernel.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> index d27f724..627d8d0 100644
> --- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> @@ -209,4 +209,17 @@
> gpios = <&gpio1 11 1>;
> };
> };
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + button@1 {
> + label = "Init Button";
> + linux,code = <116>;
> + gpios = <&gpio1 6 0>;
> + };
> + };
> +
> };
Shouldn't you add a proper pinctrl entry for this as well?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-05-02 19:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 19:43 [PATCH] ARM: kirkwood: add button for OpenBlock A6 Gregory CLEMENT
2013-05-02 19:43 ` Gregory CLEMENT
2013-05-02 19:53 ` Ezequiel Garcia [this message]
2013-05-02 19:53 ` Ezequiel Garcia
2013-05-02 19:57 ` Gregory CLEMENT
2013-05-02 19:57 ` Gregory CLEMENT
2013-05-02 21:45 ` Thomas Petazzoni
2013-05-02 21:45 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502195315.GA4107@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.