From: Ben Widawsky <ben@bwidawsk.net>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi
Subject: Re: [PATCH v2] drm/i915: unreference default context on module unload
Date: Fri, 3 May 2013 08:53:20 -0700 [thread overview]
Message-ID: <20130503155230.GA24646@bwidawsk.net> (raw)
In-Reply-To: <1367587748-643-1-git-send-email-mika.kuoppala@intel.com>
On Fri, May 03, 2013 at 04:29:08PM +0300, Mika Kuoppala wrote:
> Before module unload is called, gpu_idle() will switch
> to default context. This will increment ref count of base
> object as the default context is 'running' on module unload
> time. Unreference the drm object so that when context
> is freed, base object is freed as well.
>
> v2: added comment to explain the refcounts (Ben Widawsky)
>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
I left an r-b on the other patch. You should feel free to add it if you
actually do what I say.
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-05-03 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 10:30 [PATCH 1/2] drm/i915: reference count for i915_hw_contexts Mika Kuoppala
2013-04-30 10:30 ` [PATCH 2/2] drm/i915: unreference default context on module unload Mika Kuoppala
2013-04-30 15:49 ` Ben Widawsky
2013-05-02 8:37 ` Mika Kuoppala
2013-05-02 16:10 ` Ben Widawsky
2013-05-03 13:29 ` [PATCH v2] " Mika Kuoppala
2013-05-03 15:53 ` Ben Widawsky [this message]
2013-05-03 16:22 ` Daniel Vetter
2013-04-30 18:40 ` [PATCH 1/2] drm/i915: reference count for i915_hw_contexts Ben Widawsky
2013-04-30 21:39 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503155230.GA24646@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
--cc=miku@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.