From: Dan Carpenter <dan.carpenter@oracle.com>
To: "David S. Miller" <davem@davemloft.net>,
Neil Horman <nhorman@tuxdriver.com>
Cc: Cong Wang <amwang@redhat.com>, Eric Dumazet <edumazet@google.com>,
Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -next] netpoll: inverted down_trylock() test
Date: Mon, 06 May 2013 12:15:13 +0000 [thread overview]
Message-ID: <20130506121513.GA13930@elgon.mountain> (raw)
The return value is reversed from mutex_trylock().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index a5802a8..cec074b 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -206,7 +206,7 @@ static void netpoll_poll_dev(struct net_device *dev)
* the dev_open/close paths use this to block netpoll activity
* while changing device state
*/
- if (!down_trylock(&ni->dev_lock))
+ if (down_trylock(&ni->dev_lock))
return;
if (!netif_running(dev)) {
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "David S. Miller" <davem@davemloft.net>,
Neil Horman <nhorman@tuxdriver.com>
Cc: Cong Wang <amwang@redhat.com>, Eric Dumazet <edumazet@google.com>,
Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -next] netpoll: inverted down_trylock() test
Date: Mon, 6 May 2013 15:15:13 +0300 [thread overview]
Message-ID: <20130506121513.GA13930@elgon.mountain> (raw)
The return value is reversed from mutex_trylock().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index a5802a8..cec074b 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -206,7 +206,7 @@ static void netpoll_poll_dev(struct net_device *dev)
* the dev_open/close paths use this to block netpoll activity
* while changing device state
*/
- if (!down_trylock(&ni->dev_lock))
+ if (down_trylock(&ni->dev_lock))
return;
if (!netif_running(dev)) {
next reply other threads:[~2013-05-06 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 12:15 Dan Carpenter [this message]
2013-05-06 12:15 ` [patch -next] netpoll: inverted down_trylock() test Dan Carpenter
2013-05-06 13:00 ` Dan Carpenter
2013-05-06 13:00 ` Dan Carpenter
2013-05-06 15:08 ` David Miller
2013-05-06 15:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130506121513.GA13930@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.