Re: [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for ARM9 SOCs

[Denys Dmytriyenko <denys@ti.com>]

On Mon, May 06, 2013 at 05:56:05PM -0400, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Monday, May 06, 2013 4:32 PM
> > To: Cooper Jr., Franklin
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH] arago.conf: Correct TOOLCHAIN_BRAND for
> > ARM9 SOCs
> > 
> > On Mon, May 06, 2013 at 04:30:06PM -0500, Franklin S. Cooper Jr wrote:
> > > * Linaro toolchain does not support ARM9 architecture.
> > > * Use Arago toolchain if a ARM9 based SOC_FAMILY is being built.
> > >
> > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > > ---
> > >  meta-arago-distro/conf/distro/arago.conf |    4 +++-
> > >  1 files changed, 3 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/meta-arago-distro/conf/distro/arago.conf
> > > b/meta-arago-distro/conf/distro/arago.conf
> > > index 3954360..048c480 100644
> > > --- a/meta-arago-distro/conf/distro/arago.conf
> > > +++ b/meta-arago-distro/conf/distro/arago.conf
> > > @@ -21,7 +21,9 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2 irda
> > > largefile pcmcia usbgadget usbh
> > >
> > >  # Toolchain should be selected by setting TOOLCHAIN_BRAND in
> > > local.conf  # Set some sane defaults, in case someone forgets to set
> > > them in local.conf -TOOLCHAIN_BRAND ?= "linaro"
> > > +# ARM9 is not supported by the Linaro toolchain so default back to
> > > +the Arago # toolchain for ARM9 based SOCs.
> > > +TOOLCHAIN_BRAND ?=
> > "${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}"
> > 
> > I don't feel this belongs in the arago.conf - as the comment above says, this is
> > supposed to be set in the local.conf anyways, here it just offers a default fall
> > back...
> 
> I don't see what harm is done by tweaking the variable to insure an optimal 
> and safe default fall back is provided for all platforms we support. This 
> patch changes nothing except fixes a broken use case.

Overhead - it calls that Python function every time you evaluate 
TOOLCHAIN_BRAND variable...

I might be more lenient with something like this though:

TC_SANEDEFAULT := "${@...}"
TOOLCHAIN_BRAND ?= "${TC_SANEDEFAULT}"

Although, that would no longer work in local.conf, only arago.conf...

-- 
Denys