From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: dw_apb_timer_of.c: remove parts that were picoxcell-specific
Date: Tue, 7 May 2013 10:36:02 +0100 [thread overview]
Message-ID: <20130507093602.GA30902@page> (raw)
In-Reply-To: <20130426214313.GB24891@amd.pavel.ucw.cz>
Hi Pavel,
Apologies for the delay, but this looks good to me.
On Fri, Apr 26, 2013 at 11:43:14PM +0200, Pavel Machek wrote:
> It seems we made a mistake when creating dw_apb_timer_of.c:
> picoxcell sched_clock had parts that were not related to
> dw_apb_timer, yet we moved them to dw_apb_timer_of, and tried to
> use them on socfpga.
>
> This results in system where user/system time is not measured
> properly, as demonstrated by
>
> time dd if=/dev/urandom of=/dev/zero bs=100000 count=100
>
> So this patch switches sched_clock to hardware that exists on both
> platforms, and adds missing of_node_put() in dw_apb_timer_init().
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
Acked-by: Jamie Iles <jamie@jamieiles.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jamie Iles <jamie@jamieiles.com>
To: Pavel Machek <pavel@denx.de>
Cc: Jamie Iles <jamie@jamieiles.com>,
dinguyen@altera.com, wd@denx.de,
linux-arm-kernel@lists.infradead.org, olof@lixom.net,
arnd@arndb.de, johnstul@us.ibm.com, tglx@linutronix.de,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: dw_apb_timer_of.c: remove parts that were picoxcell-specific
Date: Tue, 7 May 2013 10:36:02 +0100 [thread overview]
Message-ID: <20130507093602.GA30902@page> (raw)
In-Reply-To: <20130426214313.GB24891@amd.pavel.ucw.cz>
Hi Pavel,
Apologies for the delay, but this looks good to me.
On Fri, Apr 26, 2013 at 11:43:14PM +0200, Pavel Machek wrote:
> It seems we made a mistake when creating dw_apb_timer_of.c:
> picoxcell sched_clock had parts that were not related to
> dw_apb_timer, yet we moved them to dw_apb_timer_of, and tried to
> use them on socfpga.
>
> This results in system where user/system time is not measured
> properly, as demonstrated by
>
> time dd if=/dev/urandom of=/dev/zero bs=100000 count=100
>
> So this patch switches sched_clock to hardware that exists on both
> platforms, and adds missing of_node_put() in dw_apb_timer_init().
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
Acked-by: Jamie Iles <jamie@jamieiles.com>
next prev parent reply other threads:[~2013-05-07 9:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 12:14 dw_apb_timer_of.c: remove parts that were picoxcell-specific Pavel Machek
2013-04-26 12:14 ` Pavel Machek
2013-04-26 12:41 ` Jamie Iles
2013-04-26 12:41 ` Jamie Iles
2013-04-26 21:37 ` Pavel Machek
2013-04-26 21:37 ` Pavel Machek
2013-04-26 21:43 ` Pavel Machek
2013-04-26 21:43 ` Pavel Machek
2013-05-06 12:48 ` Pavel Machek
2013-05-06 12:48 ` Pavel Machek
2013-05-06 13:45 ` Arnd Bergmann
2013-05-06 13:45 ` Arnd Bergmann
2013-05-06 15:53 ` Pavel Machek
2013-05-06 15:53 ` Pavel Machek
2013-05-06 21:24 ` Arnd Bergmann
2013-05-06 21:24 ` Arnd Bergmann
2013-05-07 13:57 ` Pavel Machek
2013-05-07 13:57 ` Pavel Machek
2013-05-07 16:39 ` John Stultz
2013-05-07 16:39 ` John Stultz
2013-05-07 20:11 ` Pavel Machek
2013-05-07 20:11 ` Pavel Machek
2013-05-08 0:30 ` John Stultz
2013-05-08 0:30 ` John Stultz
2013-05-10 12:38 ` Pavel Machek
2013-05-10 12:38 ` Pavel Machek
2013-05-07 20:13 ` Pavel Machek
2013-05-07 20:13 ` Pavel Machek
2013-05-07 9:36 ` Jamie Iles [this message]
2013-05-07 9:36 ` Jamie Iles
-- strict thread matches above, loose matches on Subject: below --
2013-04-23 10:58 Pavel Machek
2013-04-24 22:44 ` Dinh Nguyen
2013-04-26 11:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507093602.GA30902@page \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.